Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: build/android/pylib/local/device/local_device_gtest_run.py

Issue 2541093004: [Android] Try harder to run every gtest within each try. (Closed)
Patch Set: Tweak NOTRUN handling. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import collections 5 import collections
6 import itertools 6 import itertools
7 import logging 7 import logging
8 import os 8 import os
9 import posixpath 9 import posixpath
10 10
(...skipping 404 matching lines...) Expand 10 before | Expand all | Expand 10 after
415 resolved_tombstones = None 415 resolved_tombstones = None
416 for result in results: 416 for result in results:
417 if result.GetType() == base_test_result.ResultType.CRASH: 417 if result.GetType() == base_test_result.ResultType.CRASH:
418 if not resolved_tombstones: 418 if not resolved_tombstones:
419 resolved_tombstones = '\n'.join(tombstones.ResolveTombstones( 419 resolved_tombstones = '\n'.join(tombstones.ResolveTombstones(
420 device, 420 device,
421 resolve_all_tombstones=True, 421 resolve_all_tombstones=True,
422 include_stack_symbols=False, 422 include_stack_symbols=False,
423 wipe_tombstones=True)) 423 wipe_tombstones=True))
424 result.SetTombstones(resolved_tombstones) 424 result.SetTombstones(resolved_tombstones)
425 return results 425
426 not_run_tests = set(test).difference(set(r.GetName() for r in results))
mikecase (-- gone --) 2016/12/01 20:42:08 Could you explain this a bit. I thought you would
jbudorick 2016/12/02 01:45:21 At this point, results contains only what we were
427 return results, not_run_tests
426 428
427 #override 429 #override
428 def TearDown(self): 430 def TearDown(self):
429 @local_device_environment.handle_shard_failures 431 @local_device_environment.handle_shard_failures
430 def individual_device_tear_down(dev): 432 def individual_device_tear_down(dev):
431 for s in self._servers.get(str(dev), []): 433 for s in self._servers.get(str(dev), []):
432 s.TearDown() 434 s.TearDown()
433 435
434 tool = self.GetTool(dev) 436 tool = self.GetTool(dev)
435 tool.CleanUpEnvironment() 437 tool.CleanUpEnvironment()
436 438
437 self._env.parallel_devices.pMap(individual_device_tear_down) 439 self._env.parallel_devices.pMap(individual_device_tear_down)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698