Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 2540903002: Remove MessageLoop destruction observer from mojo::Watcher. (Closed)

Created:
4 years ago by yzshen1
Modified:
4 years ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), darin-cc_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MessageLoop destruction observer from mojo::Watcher. This CL is based on fdoray's CL http://crrev.com/2475273003 The only difference is this CL adds a message loop destruction observer for the Java watcher implementation, in order to preserve its original behavior. BUG=604762 Committed: https://crrev.com/1bd2370149a46bae21fecf9e98842ff51e8f5299 Cr-Commit-Position: refs/heads/master@{#435432}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -105 lines) Patch
M ipc/ipc_sync_channel.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M mojo/android/system/watcher_impl.cc View 1 3 chunks +72 lines, -15 lines 0 comments Download
M mojo/public/cpp/system/tests/watcher_unittest.cc View 3 chunks +4 lines, -31 lines 0 comments Download
M mojo/public/cpp/system/watcher.h View 4 chunks +0 lines, -12 lines 0 comments Download
M mojo/public/cpp/system/watcher.cc View 5 chunks +0 lines, -39 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years ago (2016-11-30 01:11:22 UTC) #6
Ken Rockot(use gerrit already)
lgtm
4 years ago (2016-11-30 19:21:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540903002/20001
4 years ago (2016-11-30 19:28:51 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 21:55:25 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-30 21:59:10 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1bd2370149a46bae21fecf9e98842ff51e8f5299
Cr-Commit-Position: refs/heads/master@{#435432}

Powered by Google App Engine
This is Rietveld 408576698