Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2536323002: Mojo C++ bindings: fix [D]CHECKs in MultiplexRouter and SyncHandleRegistry. (Closed)

Created:
4 years ago by yzshen1
Modified:
4 years ago
CC:
Aaron Boodman, abarth-chromium, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mojo C++ bindings: fix [D]CHECKs in MultiplexRouter and SyncHandleRegistry. BUG=604762 TEST=1) Remove message loop destruction observer from mojo::Watcher. 2) Run layout tests using python third_party/WebKit/Tools/Scripts/run-webkit-tests broadcastchannel/blobs.html --enable-leak-detection 3) The test should consistently pass. Committed: https://crrev.com/cfb34bcc95a51e4052f2abbef8969f46d7980464 Cr-Commit-Position: refs/heads/master@{#435374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M mojo/public/cpp/bindings/lib/multiplex_router.cc View 1 chunk +10 lines, -2 lines 0 comments Download
M mojo/public/cpp/bindings/lib/sync_handle_registry.cc View 1 chunk +9 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
yzshen1
Hi, Ken. Would you please take a look? Thanks!
4 years ago (2016-11-29 22:43:31 UTC) #4
Ken Rockot(use gerrit already)
lgtm
4 years ago (2016-11-30 19:11:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2536323002/1
4 years ago (2016-11-30 19:14:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 19:27:30 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-30 19:33:01 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cfb34bcc95a51e4052f2abbef8969f46d7980464
Cr-Commit-Position: refs/heads/master@{#435374}

Powered by Google App Engine
This is Rietveld 408576698