chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc - Issue 25409002: Update some stale TODO()s in c/b/ui/autofill.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 25409002: Update some stale TODO()s in c/b/ui/autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/account_chooser_model.cc ('k') | chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

index f56cc87a62dac9ce44106d1d9b51046609908348..4ec3e04f4c8e1770886fefa3693784f60c7583f5 100644

--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

@@ -1604,8 +1604,6 @@ bool AutofillDialogControllerImpl::FieldControlsIcons(

return type == CREDIT_CARD_NUMBER;

}

-// TODO(estade): Replace all the error messages here with more helpful and

-// translateable ones. TODO(groby): Also add tests.

Evan Stade 2013/10/01 01:53:00 do we have sufficient tests?

Dan Beam 2013/10/01 02:00:41 we have quite a few for InputsAreValid(), but I'll

string16 AutofillDialogControllerImpl::InputValidityMessage(

DialogSection section,

ServerFieldType type,

@@ -1711,8 +1709,6 @@ string16 AutofillDialogControllerImpl::InputValidityMessage(

base::string16();

}

-// TODO(estade): Replace all the error messages here with more helpful and

-// translateable ones. TODO(groby): Also add tests.

ValidityData AutofillDialogControllerImpl::InputsAreValid(

DialogSection section,

const DetailOutputMap& inputs,

@@ -2179,7 +2175,7 @@ void AutofillDialogControllerImpl::OnDidAcceptLegalDocuments() {

void AutofillDialogControllerImpl::OnDidAuthenticateInstrument(bool success) {

DCHECK(is_submitting_ && IsPayingWithWallet());

- // TODO(dbeam): use the returned full wallet. b/8332329

+ // TODO(dbeam): use the returned full wallet. http://crbug.com/224992

if (success) {

GetFullWallet();

} else {

@@ -3134,7 +3130,7 @@ void AutofillDialogControllerImpl::HandleSaveOrUpdateRequiredActions(

const std::vector<wallet::RequiredAction>& required_actions) {

DCHECK(!required_actions.empty());

- // TODO(ahutter): Invesitigate if we need to support more generic actions on

+ // TODO(ahutter): Investigate if we need to support more generic actions on

// this call such as GAIA_AUTH. See crbug.com/243457.

for (std::vector<wallet::RequiredAction>::const_iterator iter =

required_actions.begin();