Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

Issue 25409002: Update some stale TODO()s in c/b/ui/autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
index 375ec49a379fca3add8718e86b6c899ddbfb22a2..6ce5fa2ed7254777f0c863b659604ec6eccee77c 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc
@@ -1666,23 +1666,6 @@ TEST_F(AutofillDialogControllerTest, ErrorDuringSubmit) {
EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
}
-// TODO(dbeam): disallow changing accounts instead and remove this test.
-TEST_F(AutofillDialogControllerTest, ChangeAccountDuringSubmit) {
- EXPECT_CALL(*controller()->GetTestingWalletClient(),
- GetFullWallet(_)).Times(1);
-
- SubmitWithWalletItems(CompleteAndValidWalletItems());
-
- EXPECT_FALSE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
- EXPECT_FALSE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
-
- SwitchToWallet();
- SwitchToAutofill();
-
- EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
- EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
-}
-
TEST_F(AutofillDialogControllerTest, ErrorDuringVerifyCvv) {
EXPECT_CALL(*controller()->GetTestingWalletClient(),
GetFullWallet(_)).Times(1);
@@ -1699,24 +1682,6 @@ TEST_F(AutofillDialogControllerTest, ErrorDuringVerifyCvv) {
EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
}
-// TODO(dbeam): disallow changing accounts instead and remove this test.
-TEST_F(AutofillDialogControllerTest, ChangeAccountDuringVerifyCvv) {
- EXPECT_CALL(*controller()->GetTestingWalletClient(),
- GetFullWallet(_)).Times(1);
-
- SubmitWithWalletItems(CompleteAndValidWalletItems());
- controller()->OnDidGetFullWallet(CreateFullWallet("verify_cvv"));
-
- ASSERT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
- ASSERT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
-
- SwitchToWallet();
- SwitchToAutofill();
-
- EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_OK));
- EXPECT_TRUE(controller()->IsDialogButtonEnabled(ui::DIALOG_BUTTON_CANCEL));
-}
-
// Simulates receiving an INVALID_FORM_FIELD required action while processing a
// |WalletClientDelegate::OnDid{Save,Update}*()| call. This can happen if Online
// Wallet's server validation differs from Chrome's local validation.

Powered by Google App Engine
This is Rietveld 408576698