Update some stale TODO()s in c/b/ui/autofill.

Update some stale TODO()s in c/b/ui/autofill.

R=estade@chromium.org
BUG=none
TEST=less TODOs

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226434

[Dan Beam, 2013-10-01 00:31:06]

all the removed ones are TODONE(), AFAICT

[Evan Stade, 2013-10-01 01:53:00]

lgtm aside from removing the ones about tests

https://codereview.chromium.org/25409002/diff/3001/chrome/browser/ui/autofill...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (left):

https://codereview.chromium.org/25409002/diff/3001/chrome/browser/ui/autofill...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1608: //
translateable ones. TODO(groby): Also add tests.
do we have sufficient tests?

[Dan Beam, 2013-10-01 02:00:41]

https://codereview.chromium.org/25409002/diff/3001/chrome/browser/ui/autofill...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (left):

https://codereview.chromium.org/25409002/diff/3001/chrome/browser/ui/autofill...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:1608: //
translateable ones. TODO(groby): Also add tests.
On 2013/10/01 01:53:00, Evan Stade wrote:
> do we have sufficient tests?

we have quite a few for InputsAreValid(), but I'll leave for this method.

[commit-bot: I haz the power, 2013-10-01 02:01:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/25409002/8001

[commit-bot: I haz the power, 2013-10-01 02:01:17]

Failed to apply patch for
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
  Hunk #2 FAILED at 1710.
  Hunk #3 succeeded at 2195 (offset 17 lines).
  Hunk #4 succeeded at 3150 (offset 17 lines).
  1 out of 4 hunks FAILED -- saving rejects to file
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc.rej

Patch:       chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
index
f56cc87a62dac9ce44106d1d9b51046609908348..6150fc452bff11ff8fb1c246e64d5807dff52d19
100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
@@ -1604,8 +1604,7 @@ bool AutofillDialogControllerImpl::FieldControlsIcons(
   return type == CREDIT_CARD_NUMBER;
 }
 
-// TODO(estade): Replace all the error messages here with more helpful and
-// translateable ones. TODO(groby): Also add tests.
+// TODO(groby): Add more tests.
 string16 AutofillDialogControllerImpl::InputValidityMessage(
     DialogSection section,
     ServerFieldType type,
@@ -1711,8 +1710,6 @@ string16
AutofillDialogControllerImpl::InputValidityMessage(
       base::string16();
 }
 
-// TODO(estade): Replace all the error messages here with more helpful and
-// translateable ones. TODO(groby): Also add tests.
 ValidityData AutofillDialogControllerImpl::InputsAreValid(
     DialogSection section,
     const DetailOutputMap& inputs,
@@ -2179,7 +2176,7 @@ void
AutofillDialogControllerImpl::OnDidAcceptLegalDocuments() {
 void AutofillDialogControllerImpl::OnDidAuthenticateInstrument(bool success) {
   DCHECK(is_submitting_ && IsPayingWithWallet());
 
-  // TODO(dbeam): use the returned full wallet. b/8332329
+  // TODO(dbeam): use the returned full wallet. http://crbug.com/224992
   if (success) {
     GetFullWallet();
   } else {
@@ -3134,7 +3131,7 @@ void
AutofillDialogControllerImpl::HandleSaveOrUpdateRequiredActions(
     const std::vector<wallet::RequiredAction>& required_actions) {
   DCHECK(!required_actions.empty());
 
-  // TODO(ahutter): Invesitigate if we need to support more generic actions on
+  // TODO(ahutter): Investigate if we need to support more generic actions on
   // this call such as GAIA_AUTH. See crbug.com/243457.
   for (std::vector<wallet::RequiredAction>::const_iterator iter =
            required_actions.begin();

[commit-bot: I haz the power, 2013-10-01 23:51:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/25409002/11001

[commit-bot: I haz the power, 2013-10-02 00:48:57]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win_x64_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_x64_re...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-10-02 01:50:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/25409002/11001

[commit-bot: I haz the power, 2013-10-02 08:16:14]

Change committed as 226434