Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3142)

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 25409002: Update some stale TODO()s in c/b/ui/autofill. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
index bb8a2922606b5f708649d79f02fceda153723c15..0f1f921fb02e5c47f6d54402a6ad6f424e498d60 100644
--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc
@@ -1612,8 +1612,7 @@ bool AutofillDialogControllerImpl::FieldControlsIcons(
return type == CREDIT_CARD_NUMBER;
}
-// TODO(estade): Replace all the error messages here with more helpful and
-// translateable ones. TODO(groby): Also add tests.
+// TODO(groby): Add more tests.
string16 AutofillDialogControllerImpl::InputValidityMessage(
DialogSection section,
ServerFieldType type,
@@ -2204,7 +2203,7 @@ void AutofillDialogControllerImpl::OnDidAcceptLegalDocuments() {
void AutofillDialogControllerImpl::OnDidAuthenticateInstrument(bool success) {
DCHECK(is_submitting_ && IsPayingWithWallet());
- // TODO(dbeam): use the returned full wallet. b/8332329
+ // TODO(dbeam): use the returned full wallet. http://crbug.com/224992
if (success) {
GetFullWallet();
} else {
@@ -3159,7 +3158,7 @@ void AutofillDialogControllerImpl::HandleSaveOrUpdateRequiredActions(
const std::vector<wallet::RequiredAction>& required_actions) {
DCHECK(!required_actions.empty());
- // TODO(ahutter): Invesitigate if we need to support more generic actions on
+ // TODO(ahutter): Investigate if we need to support more generic actions on
// this call such as GAIA_AUTH. See crbug.com/243457.
for (std::vector<wallet::RequiredAction>::const_iterator iter =
required_actions.begin();
« no previous file with comments | « chrome/browser/ui/autofill/account_chooser_model.cc ('k') | chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698