Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2540853005: Test interstitials shouldn't use null SSLCertReporters (Closed)

Created:
4 years ago by meacer
Modified:
3 years, 11 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Test interstitials shouldn't use null SSLCertReporters CertReportHelper expects a non-null SSLCertReporter. Adding null checks in CertReportHelper will unnecessarily complicate the code, so simply disallow null reporters. BUG=554323

Patch Set 1 #

Patch Set 2 : Fix the checks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -11 lines) Patch
M chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc View 2 chunks +10 lines, -1 line 0 comments Download
M chrome/browser/ssl/cert_report_helper.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ssl/ssl_browser_tests.cc View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/interstitials/interstitial_ui.cc View 1 5 chunks +18 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (11 generated)
meacer
The CQ bit was checked by meacer@chromium.org to run a CQ dry run
4 years ago (2016-11-30 21:55:45 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540853005/1
4 years ago (2016-11-30 21:56:13 UTC) #2
meacer
Description was changed from ========== Test interstitials shouldn't use null SSLCertReporters BUG= ========== to ========== ...
4 years ago (2016-11-30 21:59:01 UTC) #3
meacer
Description was changed from ========== Test interstitials shouldn't use null SSLCertReporters CertReportHelper expects a non-null ...
4 years ago (2016-11-30 21:59:17 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-11-30 22:47:56 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/190232)
4 years ago (2016-11-30 22:47:57 UTC) #6
meacer
The CQ bit was checked by meacer@chromium.org to run a CQ dry run
4 years ago (2016-11-30 23:37:20 UTC) #7
meacer
The CQ bit was checked by meacer@chromium.org to run a CQ dry run
4 years ago (2016-11-30 23:37:50 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540853005/20001
4 years ago (2016-11-30 23:38:18 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-01 00:17:53 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-01 00:17:55 UTC) #11
Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698