Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6266)

Unified Diff: chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc

Issue 2540853005: Test interstitials shouldn't use null SSLCertReporters (Closed)
Patch Set: Fix the checks Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ssl/cert_report_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc
diff --git a/chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc b/chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc
index ad459dd348a70f0c577b9521b0bc231499e2df92..d3879763d5dce6a654c58ab6e958419e136c59b8 100644
--- a/chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc
+++ b/chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc
@@ -320,6 +320,13 @@ IN_PROC_BROWSER_TEST_F(CaptivePortalBlockingPageTest, CertReportingOptOut) {
certificate_reporting_test_utils::EXTENDED_REPORTING_DO_NOT_OPT_IN);
}
+class FakeSSLCertReporter : public SSLCertReporter {
+ public:
+ // SSLCertReporter methods:
+ void ReportInvalidCertificateChain(
+ const std::string& serialized_report) override {}
+};
+
class CaptivePortalBlockingPageIDNTest : public SecurityInterstitialIDNTest {
protected:
// SecurityInterstitialIDNTest implementation
@@ -330,7 +337,9 @@ class CaptivePortalBlockingPageIDNTest : public SecurityInterstitialIDNTest {
// Blocking page is owned by the interstitial.
CaptivePortalBlockingPage* blocking_page =
new CaptivePortalBlockingPageForTesting(
- contents, GURL(kBrokenSSL), request_url, nullptr, empty_ssl_info,
+ contents, GURL(kBrokenSSL), request_url,
+ std::unique_ptr<SSLCertReporter>(new FakeSSLCertReporter()),
+ empty_ssl_info,
base::Callback<void(content::CertificateRequestResultType)>(),
false, "");
return blocking_page;
« no previous file with comments | « no previous file | chrome/browser/ssl/cert_report_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698