Issue 254083002: Fail to create GrContext when we get a NULL for a GL/GLSL version string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 254083002: Fail to create GrContext when we get a NULL for a GL/GLSL version string (Closed)

Created:
6 years, 7 months ago by bsalomon

Modified:
6 years, 7 months ago

Reviewers:
jvanverth1

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Fail to create GrContext when we get a NULL for a GL/GLSL version string BUG=368107 Committed: http://code.google.com/p/skia/source/detail?r=14452

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -28 lines)			Patch
M	src/gpu/gl/GrGLAssembleInterface.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGLCaps.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGLCaps.cpp	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLContext.cpp	View	1 2	2 chunks	+7 lines, -4 lines	0 comments	Download
M	src/gpu/gl/GrGLExtensions.cpp	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/gpu/gl/GrGLInterface.cpp	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/gpu/gl/GrGLSL.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGLSL.cpp	View	1	1 chunk	+13 lines, -7 lines	0 comments	Download
M	src/gpu/gl/GrGLUtil.h	View	1	2 chunks	+8 lines, -5 lines	0 comments	Download
M	src/gpu/gl/GrGLUtil.cpp	View	1	4 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 5 (0 generated)

bsalomon

This fixes the tests referenced in the crbug when run in Release. I'll have a ...

6 years, 7 months ago (2014-04-29 21:04:18 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/254083002/40001

6 years, 7 months ago (2014-04-30 01:18:41 UTC) #4

Message was sent while issue was closed.

Change committed as 14452