Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2540813002: [Download Home] Use fewer AsyncTasks (Closed)

Created:
4 years ago by gone
Modified:
4 years ago
Reviewers:
Ted C
CC:
chromium-reviews, asanka, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Download Home] Use fewer AsyncTasks Download updates cause a new AsyncTask to be created and executed, resulting in a potential to overrun the Executor's queue size. While it will result in less up-to-date values for free space, settle for just having one AsyncTask that can be in play at once by explicitly checking if another AsyncTask is already running. Moreover, catch any exceptions that may fire if we still overflow the queue with our single task. BUG=669493 Committed: https://crrev.com/731bb5908b6f2c782efc2fd1ef05a3ec72d1d822 Cr-Commit-Position: refs/heads/master@{#435745}

Patch Set 1 #

Patch Set 2 : Fix tests #

Patch Set 3 : Remove accidental thing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -14 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/ui/SpaceDisplay.java View 5 chunks +19 lines, -10 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadActivityTest.java View 1 2 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
gone
4 years ago (2016-11-29 19:54:08 UTC) #2
gone
Swapping out; Ted can you take a look?
4 years ago (2016-12-01 18:22:18 UTC) #4
Ted C
lgtm
4 years ago (2016-12-01 18:32:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540813002/1
4 years ago (2016-12-01 18:33:31 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/190879)
4 years ago (2016-12-01 20:06:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540813002/40001
4 years ago (2016-12-01 22:11:02 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-01 22:46:45 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-01 22:49:06 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/731bb5908b6f2c782efc2fd1ef05a3ec72d1d822
Cr-Commit-Position: refs/heads/master@{#435745}

Powered by Google App Engine
This is Rietveld 408576698