Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h

Issue 2540653003: Implement collection of out-of-flow descendants (Closed)
Patch Set: Collection of out-of-flow descendants Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h b/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h
index de0a662ad5477d040af68dd3d1535dddb176f4b1..d0ea5953e41f309c99a0f9dc30ed7ab243c96188 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h
+++ b/third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h
@@ -22,7 +22,7 @@ class CORE_EXPORT NGPhysicalFragment final : public NGPhysicalFragmentBase {
NGPhysicalSize overflow,
HeapVector<Member<const NGPhysicalFragmentBase>>& children,
HeapLinkedHashSet<WeakMember<NGBlockNode>>& out_of_flow_descendants,
- Vector<NGLogicalOffset> out_of_flow_offsets,
+ Vector<NGCorner> out_of_flow_offsets,
NGMarginStrut margin_strut);
const HeapVector<Member<const NGPhysicalFragmentBase>>& Children() const {
@@ -34,7 +34,7 @@ class CORE_EXPORT NGPhysicalFragment final : public NGPhysicalFragmentBase {
return out_of_flow_descendants_;
}
- const Vector<NGLogicalOffset>& OutOfFlowOffsets() const {
+ const Vector<NGCorner>& OutOfFlowOffsets() const {
ikilpatrick 2016/12/02 21:06:13 offsets isn't a good name now, can you fix now or
atotic 2016/12/02 22:19:37 done
return out_of_flow_offsets_;
}
@@ -45,7 +45,7 @@ class CORE_EXPORT NGPhysicalFragment final : public NGPhysicalFragmentBase {
private:
HeapVector<Member<const NGPhysicalFragmentBase>> children_;
HeapLinkedHashSet<WeakMember<NGBlockNode>> out_of_flow_descendants_;
- Vector<NGLogicalOffset> out_of_flow_offsets_;
+ Vector<NGCorner> out_of_flow_offsets_;
NGMarginStrut margin_strut_;
};

Powered by Google App Engine
This is Rietveld 408576698