Implement collection of out-of-flow descendants

third_party/WebKit/Source/core/layout/ng/ng_physical_fragment.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NGPhysicalFragment_h
 #define NGPhysicalFragment_h
 
 #include "core/CoreExport.h"
 #include "core/layout/ng/ng_physical_fragment_base.h"
 #include "core/layout/ng/ng_units.h"
 #include "platform/heap/Handle.h"
 
 namespace blink {
 
 class NGBlockNode;
 
 class CORE_EXPORT NGPhysicalFragment final : public NGPhysicalFragmentBase {
  public:
   // This modifies the passed-in children vector.
   NGPhysicalFragment(
       NGPhysicalSize size,
       NGPhysicalSize overflow,
       HeapVector<Member<const NGPhysicalFragmentBase>>& children,
       HeapLinkedHashSet<WeakMember<NGBlockNode>>& out_of_flow_descendants,
-      Vector<NGLogicalOffset> out_of_flow_offsets,
+      Vector<NGCorner> out_of_flow_offsets,
       NGMarginStrut margin_strut);
 
   const HeapVector<Member<const NGPhysicalFragmentBase>>& Children() const {
     return children_;
   }
 
   const HeapLinkedHashSet<WeakMember<NGBlockNode>>& OutOfFlowDescendants()
       const {
     return out_of_flow_descendants_;
   }
 
-  const Vector<NGLogicalOffset>& OutOfFlowOffsets() const {
+  const Vector<NGCorner>& OutOfFlowOffsets() const {

[ikilpatrick, 2016/12/02 21:06:13]

offsets isn't a good name now, can you fix now or in a followup patch?

e.g.
OutOfFlowStaticPositions

[atotic, 2016/12/02 22:19:37]

done

     return out_of_flow_offsets_;
   }
 
   NGMarginStrut MarginStrut() const { return margin_strut_; }
 
   DECLARE_TRACE_AFTER_DISPATCH();
 
  private:
   HeapVector<Member<const NGPhysicalFragmentBase>> children_;
   HeapLinkedHashSet<WeakMember<NGBlockNode>> out_of_flow_descendants_;
-  Vector<NGLogicalOffset> out_of_flow_offsets_;
+  Vector<NGCorner> out_of_flow_offsets_;
   NGMarginStrut margin_strut_;
 };
 
 WILL_NOT_BE_EAGERLY_TRACED_CLASS(NGPhysicalFragment);
 
 DEFINE_TYPE_CASTS(NGPhysicalFragment,
                   NGPhysicalFragmentBase,
                   fragment,
                   fragment->Type() == NGPhysicalFragmentBase::kFragmentBox,
                   fragment.Type() == NGPhysicalFragmentBase::kFragmentBox);
 
 }  // namespace blink
 
 #endif  // NGPhysicalFragment_h