Chromium Code Reviews| Index: chrome/android/java/res/layout/download_manager_ui_space_widget.xml |
| diff --git a/chrome/android/java/res/layout/download_manager_ui_space_widget.xml b/chrome/android/java/res/layout/download_manager_ui_space_widget.xml |
| index 2840692b5094ee4e7b2261221028897fe5e677b1..a7e7fa3f6e702e2a0af8e7c5c6d0cf4fb94fec9c 100644 |
| --- a/chrome/android/java/res/layout/download_manager_ui_space_widget.xml |
| +++ b/chrome/android/java/res/layout/download_manager_ui_space_widget.xml |
| @@ -5,11 +5,18 @@ |
| <merge xmlns:android="http://schemas.android.com/apk/res/android"> |
| + <!-- Values in this file are a best effort attempt to match the dimensions in the "spec", which |
| + had to be heavily interpreted for implementation. |
| + |
| + https://bugs.chromium.org/p/chromium/issues/detail?id=658246&desc=2#c18 |
| + --> |
|
Theresa
2016/11/29 00:37:13
While this is certainly useful for reviewing the C
gone
2016/11/29 00:48:20
Was trying to refer to the comments following spec
|
| <LinearLayout |
| android:layout_width="match_parent" |
| android:layout_height="wrap_content" |
| android:layout_marginStart="@dimen/drawer_margin_large" |
| android:layout_marginEnd="@dimen/drawer_margin_large" |
| + android:paddingTop="26dp" |
| + android:paddingBottom="24dp" |
| android:orientation="vertical" > |
| <TextView |
| @@ -20,7 +27,7 @@ |
| android:textColor="@color/light_active_color" |
| android:textSize="20sp" /> |
| - <!-- The widget ends up claiming 32dp of space, vertically. --> |
| + <!-- The progress bar uses 32dp of space, vertically, including spacing. --> |
| <ProgressBar |
| android:id="@+id/space_bar" |
| style="@style/MaterialProgressBar" |
| @@ -35,16 +42,15 @@ |
| android:layout_height="wrap_content" |
| android:singleLine="true" |
| android:textColor="@color/google_grey_600" |
| - android:textSize="14sp" /> |
| + android:textSize="12sp" /> |
| <TextView |
| android:id="@+id/size_free" |
| android:layout_width="match_parent" |
| android:layout_height="wrap_content" |
| - android:layout_marginBottom="22dp" |
| android:singleLine="true" |
| - android:textColor="@color/material_progressbar_bg" |
| - android:textSize="14sp" /> |
| + android:textColor="@color/google_grey_400" |
| + android:textSize="12sp" /> |
| </LinearLayout> |