Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2540513005: Cleanup SVGMarkerData::updateFromPathElement (Closed)

Created:
4 years ago by fs
Modified:
4 years ago
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup SVGMarkerData::updateFromPathElement Make the updateFromPathElement "closure" a simple thunk-style function, to make it a little less unwieldy. Also pass PathElement& rather than PathElement*. BUG=633012, 450368 Committed: https://crrev.com/cb0f17992844eca710c660cb4ce25d0686a184b3 Cr-Commit-Position: refs/heads/master@{#434987}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M third_party/WebKit/Source/core/layout/svg/SVGMarkerData.h View 2 chunks +20 lines, -20 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (8 generated)
fs
4 years ago (2016-11-29 13:03:43 UTC) #4
f(malita)
lgtm
4 years ago (2016-11-29 14:29:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2540513005/1
4 years ago (2016-11-29 14:57:07 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 15:01:04 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-29 15:03:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cb0f17992844eca710c660cb4ce25d0686a184b3
Cr-Commit-Position: refs/heads/master@{#434987}

Powered by Google App Engine
This is Rietveld 408576698