Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2539763002: Use the right point for marker orientation when closing a subpath (Closed)

Created:
4 years ago by fs
Modified:
4 years ago
CC:
fs, blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the right point for marker orientation when closing a subpath Path::apply doesn't pass a point along for the PathElementCloseSubpath command. This would yield the wrong orientation on the last marker-mid on the path (see crbug.com/633012#c1 for an example.) Use m_subpathStart where needed instead. BUG=633012 Committed: https://crrev.com/f5372970166aa5d5124da806c698558d27e2dad5 Cr-Commit-Position: refs/heads/master@{#434988}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/svg/markers/marker-orientation-close-path.html View 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/markers/marker-orientation-close-path-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGMarkerData.h View 2 chunks +6 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
fs
4 years ago (2016-11-29 14:33:57 UTC) #6
f(malita)
lgtm
4 years ago (2016-11-29 14:37:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539763002/1
4 years ago (2016-11-29 15:03:45 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 15:07:50 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-29 15:10:59 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f5372970166aa5d5124da806c698558d27e2dad5
Cr-Commit-Position: refs/heads/master@{#434988}

Powered by Google App Engine
This is Rietveld 408576698