Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2540513002:
Move GPU proc message loop to heap (Closed)
|
Created:
4 years ago by ericrk Modified:
4 years ago Reviewers:
Ken Russell (switch to Gerrit) CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMove GPU proc message loop to heap
We are experiencing what appear to be memory-stomp issues in the GPU
process. These issues seem to be impacting the message loop and
listeners registered to it, such as the GPU watchdog thread. This
change moves the message loop from the stack to a heap object as an
experiment to see if it improves things.
BUG=662802
Committed: https://crrev.com/1d9e17fe08c0dd44fa7e525662569f921e241bfc
Cr-Commit-Position: refs/heads/master@{#435117}
Patch Set 1 : Make GPU proc message loop on heap #
Total comments: 1
Patch Set 2 : Add bugs to comment #Messages
Total messages: 21 (16 generated)
Description was changed from ========== Make GPU proc message loop on heap We are experiencing what appear to be memory-stomp issues int he GPU process. These issues seem to be impacting the message loop and listeners registered to it. This change moves the message loop from the stack to a heap object in order to help guard against this. R=vmiura BUG=662802 ========== to ========== Move GPU proc message loop to heap We are experiencing what appear to be memory-stomp issues int he GPU process. These issues seem to be impacting the message loop and listeners registered to it. This change moves the message loop from the stack to a heap object in order to help guard against this. R=vmiura BUG=662802 ==========
Description was changed from ========== Move GPU proc message loop to heap We are experiencing what appear to be memory-stomp issues int he GPU process. These issues seem to be impacting the message loop and listeners registered to it. This change moves the message loop from the stack to a heap object in order to help guard against this. R=vmiura BUG=662802 ========== to ========== Move GPU proc message loop to heap We are experiencing what appear to be memory-stomp issues int he GPU process. These issues seem to be impacting the message loop and listeners registered to it. This change moves the message loop from the stack to a heap object as an experiment to see if it improves things. BUG=662802 ==========
ericrk@chromium.org changed reviewers: - vmiura@chromium.org
Description was changed from ========== Move GPU proc message loop to heap We are experiencing what appear to be memory-stomp issues int he GPU process. These issues seem to be impacting the message loop and listeners registered to it. This change moves the message loop from the stack to a heap object as an experiment to see if it improves things. BUG=662802 ========== to ========== Move GPU proc message loop to heap We are experiencing what appear to be memory-stomp issues in the GPU process. These issues seem to be impacting the message loop and listeners registered to it. This change moves the message loop from the stack to a heap object as an experiment to see if it improves things. BUG=662802 ==========
Description was changed from ========== Move GPU proc message loop to heap We are experiencing what appear to be memory-stomp issues in the GPU process. These issues seem to be impacting the message loop and listeners registered to it. This change moves the message loop from the stack to a heap object as an experiment to see if it improves things. BUG=662802 ========== to ========== Move GPU proc message loop to heap We are experiencing what appear to be memory-stomp issues in the GPU process. These issues seem to be impacting the message loop and listeners registered to it, such as the GPU watchdog thread. This change moves the message loop from the stack to a heap object as an experiment to see if it improves things. BUG=662802 ==========
ericrk@chromium.org changed reviewers: + kbr@chromium.org
Patchset #1 (id:1) has been deleted
Hi Ken, This is an experiment to see if we can improve some of the GPU watchdog thread issues we've been experiencing. Won't "fix" the issue, but may make the watchdog thread more robust against it.
Very interesting. LGTM as an experiment. I linked this bug to another one which has been around for a while with the same symptom. https://codereview.chromium.org/2540513002/diff/20001/content/gpu/gpu_main.cc File content/gpu/gpu_main.cc (right): https://codereview.chromium.org/2540513002/diff/20001/content/gpu/gpu_main.cc... content/gpu/gpu_main.cc:199: // this. Please refer to the bug ID in the comment. Thanks.
The CQ bit was checked by ericrk@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by ericrk@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org Link to the patchset: https://codereview.chromium.org/2540513002/#ps40001 (title: "Add bugs to comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480463070128220,
"parent_rev": "e5d98cac7b82ff7dc4967e61cfde4380db52bc33", "commit_rev":
"1d6f321feb987ff4405479cd3b235d29e84eff1d"}
Message was sent while issue was closed.
Description was changed from ========== Move GPU proc message loop to heap We are experiencing what appear to be memory-stomp issues in the GPU process. These issues seem to be impacting the message loop and listeners registered to it, such as the GPU watchdog thread. This change moves the message loop from the stack to a heap object as an experiment to see if it improves things. BUG=662802 ========== to ========== Move GPU proc message loop to heap We are experiencing what appear to be memory-stomp issues in the GPU process. These issues seem to be impacting the message loop and listeners registered to it, such as the GPU watchdog thread. This change moves the message loop from the stack to a heap object as an experiment to see if it improves things. BUG=662802 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Move GPU proc message loop to heap We are experiencing what appear to be memory-stomp issues in the GPU process. These issues seem to be impacting the message loop and listeners registered to it, such as the GPU watchdog thread. This change moves the message loop from the stack to a heap object as an experiment to see if it improves things. BUG=662802 ========== to ========== Move GPU proc message loop to heap We are experiencing what appear to be memory-stomp issues in the GPU process. These issues seem to be impacting the message loop and listeners registered to it, such as the GPU watchdog thread. This change moves the message loop from the stack to a heap object as an experiment to see if it improves things. BUG=662802 Committed: https://crrev.com/1d9e17fe08c0dd44fa7e525662569f921e241bfc Cr-Commit-Position: refs/heads/master@{#435117} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1d9e17fe08c0dd44fa7e525662569f921e241bfc Cr-Commit-Position: refs/heads/master@{#435117} |
