Reland "Propagate information about how ARC apps are launched"

chrome/browser/ui/webui/options/browser_options_handler.cc

Index: chrome/browser/ui/webui/options/browser_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/browser_options_handler.cc b/chrome/browser/ui/webui/options/browser_options_handler.cc
index 08fdcf647721fab6bfd366aa2e3e89c7cd11188d..6fab852cf89969687c447167e52a1f5ecc37dd0b 100644
--- a/chrome/browser/ui/webui/options/browser_options_handler.cc
+++ b/chrome/browser/ui/webui/options/browser_options_handler.cc
@@ -2008,7 +2008,15 @@ void BrowserOptionsHandler::ShowAndroidAppsSettings(
     return;
   }
 
-  arc::LaunchAndroidSettingsApp(profile);
+  // We only care whether the event came from a keyboard or non-keyboard
+  // (mouse/touch). Set the default flags in such a way that it would appear
+  // that it came from a mouse by default.
+  int flags = ui::EF_LEFT_MOUSE_BUTTON;

[stevenjb, 2016/11/29 20:17:10]

Again, since what we really care about is whether this was a keyboard event, I
think the parameter would be more clear as "from_keyboard".

[Luis Héctor Chávez, 2016/11/29 20:50:46]

Done.

+  bool is_mouse_or_touch = true;
+  if (args->GetBoolean(0, &is_mouse_or_touch) && !is_mouse_or_touch)
+    flags = ui::EF_NONE;

[stevenjb, 2016/11/29 20:17:10]

nit:

int flags = is_mouse_or_touch ? ui::EF_LEFT_MOUSE_BUTTON : ui::EF_NONE;

[Luis Héctor Chávez, 2016/11/29 20:50:46]

Done.

+
+  arc::LaunchAndroidSettingsApp(profile, flags);
 }
 
 void BrowserOptionsHandler::ShowAccessibilityTalkBackSettings(