Reland "Propagate information about how ARC apps are launched"

chrome/browser/ui/webui/options/browser_options_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/options/browser_options_handler.h"
 
 #include <stddef.h>
 
 #include <set>
 #include <utility>
@@ skipping 1990 matching lines @@
 
 void BrowserOptionsHandler::ShowAndroidAppsSettings(
     const base::ListValue* args) {
   Profile* profile = Profile::FromWebUI(web_ui());
   // Settings in secondary profile cannot access ARC.
   if (!arc::ArcSessionManager::IsAllowedForProfile(profile)) {
     LOG(ERROR) << "Settings can't be invoked for non-primary profile";
     return;
   }
 
-  arc::LaunchAndroidSettingsApp(profile);
+  // We only care whether the event came from a keyboard or non-keyboard
+  // (mouse/touch). Set the default flags in such a way that it would appear
+  // that it came from a mouse by default.
+  int flags = ui::EF_LEFT_MOUSE_BUTTON;

[stevenjb, 2016/11/29 20:17:10]

Again, since what we really care about is whether this was a keyboard event, I
think the parameter would be more clear as "from_keyboard".

[Luis Héctor Chávez, 2016/11/29 20:50:46]

Done.

+  bool is_mouse_or_touch = true;
+  if (args->GetBoolean(0, &is_mouse_or_touch) && !is_mouse_or_touch)
+    flags = ui::EF_NONE;

[stevenjb, 2016/11/29 20:17:10]

nit:

int flags = is_mouse_or_touch ? ui::EF_LEFT_MOUSE_BUTTON : ui::EF_NONE;

[Luis Héctor Chávez, 2016/11/29 20:50:46]

Done.

+
+  arc::LaunchAndroidSettingsApp(profile, flags);
 }
 
 void BrowserOptionsHandler::ShowAccessibilityTalkBackSettings(
     const base::ListValue *args) {
   Profile* profile = Profile::FromWebUI(web_ui());
   // Settings in secondary profile cannot access ARC.
   if (!arc::ArcSessionManager::IsAllowedForProfile(profile)) {
     LOG(WARNING) << "Settings can't be invoked for non-primary profile";
     return;
   }
@@ skipping 268 matching lines @@
 
 bool BrowserOptionsHandler::IsDeviceOwnerProfile() {
 #if defined(OS_CHROMEOS)
   return chromeos::ProfileHelper::IsOwnerProfile(Profile::FromWebUI(web_ui()));
 #else
   return true;
 #endif
 }
 
 }  // namespace options