third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.h - Issue 2540423003: Revert "Notifications: Split up image loading histograms by image type"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.h

Issue 2540423003: Revert "Notifications: Split up image loading histograms by image type" (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/notifications/NotificationImageLoaderTest.cpp ('k') | third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.h

diff --git a/third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.h b/third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.h

index 4ab17e9d9cbc4c1c7ba6efecbe22e8dcb793cc54..8f110429feceace35cef349f13d0036054b1f94d 100644

--- a/third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.h

+++ b/third_party/WebKit/Source/modules/notifications/NotificationResourcesLoader.h

@@ -56,7 +56,6 @@ class MODULES_EXPORT NotificationResourcesLoader final

private:

void loadImage(ExecutionContext*,

- NotificationImageLoader::Type,

const KURL&,

std::unique_ptr<NotificationImageLoader::ImageCallback>);

void didLoadImage(const SkBitmap& image);