Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2540373002: Merge M56: "Fail decodeAudioFileData() when duration is unknown." (Closed)

Created:
4 years ago by DaleCurtis
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Merge M56: "Fail decodeAudioFileData() when duration is unknown." This API as currently written can only work with streams of a known duration, so explicitly fail instead of misinterpreting a massive 64-bit value as the actual duration. BUG=668849 TEST=new unittest and layout test. Review-Url: https://codereview.chromium.org/2537603003 Cr-Commit-Position: refs/heads/master@{#435118} (cherry picked from commit f7f6a8ef3024fe72f77d74426e69a8f3fa54c3f5) Committed: https://chromium.googlesource.com/chromium/src/+/06a5c7686f5355f8b173060567d033e552cbebbd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M media/filters/audio_file_reader.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M media/filters/audio_file_reader_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/decode-audio-data-basic.html View 3 chunks +17 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/decode-audio-data-basic-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
DaleCurtis
4 years ago (2016-12-01 01:25:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
06a5c7686f5355f8b173060567d033e552cbebbd.

Powered by Google App Engine
This is Rietveld 408576698