Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2537603003: Fail decodeAudioFileData() when duration is unknown. (Closed)

Created:
4 years ago by DaleCurtis
Modified:
4 years ago
Reviewers:
Raymond Toy
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fail decodeAudioFileData() when duration is unknown. This API as currently written can only work with streams of a known duration, so explicitly fail instead of misinterpreting a massive 64-bit value as the actual duration. BUG=668849 TEST=new unittest and layout test. Committed: https://crrev.com/f7f6a8ef3024fe72f77d74426e69a8f3fa54c3f5 Cr-Commit-Position: refs/heads/master@{#435118}

Patch Set 1 #

Patch Set 2 : Add tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -3 lines) Patch
M media/filters/audio_file_reader.cc View 2 chunks +7 lines, -2 lines 0 comments Download
M media/filters/audio_file_reader_unittest.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/decode-audio-data-basic.html View 1 3 chunks +17 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/decode-audio-data-basic-expected.txt View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
DaleCurtis
4 years ago (2016-11-29 00:28:22 UTC) #2
Raymond Toy
lgtm. Do you have a test file for this? If so, it would be great ...
4 years ago (2016-11-29 16:18:01 UTC) #3
DaleCurtis
Yup. Done. PTAL.
4 years ago (2016-11-29 21:09:51 UTC) #5
Raymond Toy
lgtm. Thanks for doing this!
4 years ago (2016-11-29 21:16:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537603003/20001
4 years ago (2016-11-29 21:36:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-11-29 23:39:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2537603003/20001
4 years ago (2016-11-29 23:44:06 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 01:53:17 UTC) #14
commit-bot: I haz the power
4 years ago (2016-11-30 01:58:54 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f7f6a8ef3024fe72f77d74426e69a8f3fa54c3f5
Cr-Commit-Position: refs/heads/master@{#435118}

Powered by Google App Engine
This is Rietveld 408576698