Source/bindings/v8/custom/V8HTMLSelectElementCustom.cpp - Issue 25403004: [oilpan] Figure out lifetime of remaining Node raw pointers (Part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8HTMLSelectElementCustom.cpp

Issue 25403004: [oilpan] Figure out lifetime of remaining Node raw pointers (Part 2) (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/v8/custom/V8HTMLMediaElementCustom.cpp ('k') | Source/core/dom/CheckedRadioButtons.cpp » ('j') | Source/core/dom/CheckedRadioButtons.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8HTMLSelectElementCustom.cpp

diff --git a/Source/bindings/v8/custom/V8HTMLSelectElementCustom.cpp b/Source/bindings/v8/custom/V8HTMLSelectElementCustom.cpp

index ee19d921d9db6da67c9f05143f520c25d4194dd3..61a545ac3c333f53734271b0fcd413818f0f344a 100644

--- a/Source/bindings/v8/custom/V8HTMLSelectElementCustom.cpp

+++ b/Source/bindings/v8/custom/V8HTMLSelectElementCustom.cpp

@@ -73,7 +73,7 @@ v8::Handle<v8::Value> V8HTMLSelectElement::removeMethodCustom(const v8::Argument

v8::Handle<v8::Value> removeElement(HTMLSelectElement* imp, const v8::Arguments& args)

{

if (V8HTMLOptionElement::HasInstance(args[0], args.GetIsolate(), worldType(args.GetIsolate()))) {

- HTMLOptionElement* element = V8HTMLOptionElement::toNative(v8::Handle<v8::Object>::Cast(args[0]));

+ Handle<HTMLOptionElement> element = adoptRawResult(V8HTMLOptionElement::toNative(v8::Handle<v8::Object>::Cast(args[0])));

imp->remove(element->index());

return v8::Undefined();

}