Source/bindings/v8/custom/V8HTMLMediaElementCustom.cpp - Issue 25403004: [oilpan] Figure out lifetime of remaining Node raw pointers (Part 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8HTMLMediaElementCustom.cpp

Issue 25403004: [oilpan] Figure out lifetime of remaining Node raw pointers (Part 2) (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/v8/custom/V8HTMLLinkElementCustom.cpp ('k') | Source/bindings/v8/custom/V8HTMLSelectElementCustom.cpp » ('j') | Source/core/dom/CheckedRadioButtons.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/v8/custom/V8HTMLMediaElementCustom.cpp

diff --git a/Source/bindings/v8/custom/V8HTMLMediaElementCustom.cpp b/Source/bindings/v8/custom/V8HTMLMediaElementCustom.cpp

index b296595c16a9711e10df8ec7e10e41d0a8da5214..14740f957caebc2c022efd6ee7c722e0e00da5f6 100644

--- a/Source/bindings/v8/custom/V8HTMLMediaElementCustom.cpp

+++ b/Source/bindings/v8/custom/V8HTMLMediaElementCustom.cpp

@@ -44,7 +44,7 @@ void V8HTMLMediaElement::controllerAttrSetterCustom(v8::Local<v8::String>, v8::L

// 4.8.10.11.2 Media controllers: controller attribute.

// On setting, it must first remove the element's mediagroup attribute, if any,

- HTMLMediaElement* imp = V8HTMLMediaElement::toNative(info.Holder());

+ Handle<HTMLMediaElement> imp = adoptRawResult(V8HTMLMediaElement::toNative(info.Holder()));

imp->setMediaGroup(String());

// and then set the current media controller to the given value.

imp->setController(controller);