Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Unified Diff: Source/bindings/v8/BindingSecurity.h

Issue 25403004: [oilpan] Figure out lifetime of remaining Node raw pointers (Part 2) (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/v8/BindingSecurity.cpp » ('j') | Source/core/dom/CheckedRadioButtons.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/BindingSecurity.h
diff --git a/Source/bindings/v8/BindingSecurity.h b/Source/bindings/v8/BindingSecurity.h
index 525781be6f0b6fdee6e5e539a3eb1238506cf2f0..7d5a0bc087a5bf29744b8ec599bb9648ffb04005 100644
--- a/Source/bindings/v8/BindingSecurity.h
+++ b/Source/bindings/v8/BindingSecurity.h
@@ -47,13 +47,11 @@ enum SecurityReportingOption {
class BindingSecurity {
public:
- // FIXME(oilpan): remove this function once Node* is fully handlified.
- static bool shouldAllowAccessToNode(BindingState*, Node*);
static bool shouldAllowAccessToNode(BindingState*, const Handle<Node>&);
static bool shouldAllowAccessToDOMWindow(BindingState*, DOMWindow*, SecurityReportingOption = ReportSecurityError);
static bool shouldAllowAccessToFrame(BindingState*, Frame*, SecurityReportingOption = ReportSecurityError);
- static bool allowSettingFrameSrcToJavascriptUrl(BindingState*, HTMLFrameElementBase*, const String& value);
+ static bool allowSettingFrameSrcToJavascriptUrl(BindingState*, const Handle<HTMLFrameElementBase>&, const String& value);
};
}
« no previous file with comments | « no previous file | Source/bindings/v8/BindingSecurity.cpp » ('j') | Source/core/dom/CheckedRadioButtons.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698