Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: Source/bindings/v8/BindingSecurity.cpp

Issue 25403004: [oilpan] Figure out lifetime of remaining Node raw pointers (Part 2) (Closed) Base URL: svn://svn.chromium.org/blink/branches/oilpan
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/BindingSecurity.cpp
diff --git a/Source/bindings/v8/BindingSecurity.cpp b/Source/bindings/v8/BindingSecurity.cpp
index fa9af5376383b31bd287c529d9cc0918a4fbe69f..618df528894944fd2cbe3c57d8d8feb9f8831186 100644
--- a/Source/bindings/v8/BindingSecurity.cpp
+++ b/Source/bindings/v8/BindingSecurity.cpp
@@ -70,17 +70,12 @@ bool BindingSecurity::shouldAllowAccessToFrame(BindingState* state, Frame* targe
return target && canAccessDocument(state, target->document(), reportingOption);
}
-bool BindingSecurity::shouldAllowAccessToNode(BindingState* state, Node* target)
-{
- return target && canAccessDocument(state, target->document());
-}
-
bool BindingSecurity::shouldAllowAccessToNode(BindingState* state, const Handle<Node>& node)
{
- return shouldAllowAccessToNode(state, node.raw());
+ return node && canAccessDocument(state, node->document());
}
-bool BindingSecurity::allowSettingFrameSrcToJavascriptUrl(BindingState* state, HTMLFrameElementBase* frame, const String& value)
+bool BindingSecurity::allowSettingFrameSrcToJavascriptUrl(BindingState* state, const Handle<HTMLFrameElementBase>& frame, const String& value)
{
return !protocolIsJavaScript(stripLeadingAndTrailingHTMLSpaces(value)) || canAccessDocument(state, frame->contentDocument());
}

Powered by Google App Engine
This is Rietveld 408576698