third_party/WebKit/Source/modules/mediacapturefromelement/CanvasCaptureMediaStreamTrack.cpp - Issue 2540263003: Carry MediaStreamComponent properties on clone.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediacapturefromelement/CanvasCaptureMediaStreamTrack.cpp

Issue 2540263003: Carry MediaStreamComponent properties on clone. (Closed)

Patch Set: added test + todo comments Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/mediastream/MediaStreamTrack-clone.html ('k') | third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediacapturefromelement/CanvasCaptureMediaStreamTrack.cpp

diff --git a/third_party/WebKit/Source/modules/mediacapturefromelement/CanvasCaptureMediaStreamTrack.cpp b/third_party/WebKit/Source/modules/mediacapturefromelement/CanvasCaptureMediaStreamTrack.cpp

index 4c8d7d9615f9adf74d1ed29c484b633ed23a02d6..6a8fdaa8b046baf8e6da48c42e589ef639b25669 100644

--- a/third_party/WebKit/Source/modules/mediacapturefromelement/CanvasCaptureMediaStreamTrack.cpp

+++ b/third_party/WebKit/Source/modules/mediacapturefromelement/CanvasCaptureMediaStreamTrack.cpp

@@ -40,8 +40,7 @@ void CanvasCaptureMediaStreamTrack::requestFrame() {

CanvasCaptureMediaStreamTrack* CanvasCaptureMediaStreamTrack::clone(

ExecutionContext* context) {

- MediaStreamComponent* clonedComponent =

- MediaStreamComponent::create(component()->source());

+ MediaStreamComponent* clonedComponent = component()->clone();

CanvasCaptureMediaStreamTrack* clonedTrack =

new CanvasCaptureMediaStreamTrack(*this, clonedComponent);

MediaStreamCenter::instance().didCreateMediaStreamTrack(clonedComponent);