Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Unified Diff: third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp

Issue 2540263003: Carry MediaStreamComponent properties on clone. (Closed)
Patch Set: added test + todo comments Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
diff --git a/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp b/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
index 0e4d5d1bcbbe7e34daaa156646d2de57a5faa3d2..f27b7dbb68e2694b0d328e1af049050618130c41 100644
--- a/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
+++ b/third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp
@@ -139,8 +139,9 @@ void MediaStreamTrack::stopTrack(ExceptionState& exceptionState) {
}
MediaStreamTrack* MediaStreamTrack::clone(ExecutionContext* context) {
- MediaStreamComponent* clonedComponent =
- MediaStreamComponent::create(component()->source());
+ // TODO(pbos): Make sure m_readyState and m_stopped carries over on cloned
+ // tracks.
+ MediaStreamComponent* clonedComponent = component()->clone();
MediaStreamTrack* clonedTrack =
MediaStreamTrack::create(context, clonedComponent);
MediaStreamCenter::instance().didCreateMediaStreamTrack(clonedComponent);

Powered by Google App Engine
This is Rietveld 408576698