Carry MediaStreamComponent properties on clone.

Carry MediaStreamComponent properties on clone.

Adds a clone() method to MediaStreamComponent that carries over enabled
and muted state which should carry over when cloning a MediaStreamTrack.

MediaStreamTrack's id intentionally does not carry over and remains
unique.

R=guidou@chromium.org,esprehn@chromium.org
BUG=669212
Committed: https://crrev.com/b38248f051bc2022527cfb09040050ed15b23d8e
Cr-Commit-Position: refs/heads/master@{#435656}

[pbos, 2016-11-30 21:04:09]

pbos@chromium.org changed reviewers:
+ esprehn@chromium.org, hta@chromium.org

[pbos, 2016-11-30 21:04:10]

PTAL, esprehn@ suggested by git cl owners, please update if there's someone more
suited.

[pbos, 2016-11-30 21:04:27]

Description was changed from

==========
Carry MediaStreamComponent properties on clone.

Adds a clone() method to MediaStreamComponent that carries over enabled
and muted state which should carry over when cloning a MediaStreamTrack.
MediaStreamTrack's id intentionally does not carry over and remains
unique.

R=guidou@chromium.org
BUG=669212
==========

to

==========
Carry MediaStreamComponent properties on clone.

Adds a clone() method to MediaStreamComponent that carries over enabled
and muted state which should carry over when cloning a MediaStreamTrack.
MediaStreamTrack's id intentionally does not carry over and remains
unique.

R=guidou@chromium.org,hta@chromium.org,esprehn@chromium.org
BUG=669212
==========

[pbos, 2016-11-30 21:05:03]

Note that this CL doesn't fix properties of MediaStreamTrack that are outside
MediaStreamComponent (e.g. m_stopped or m_readyState).

[pbos, 2016-11-30 21:05:13]

The CQ bit was checked by pbos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 21:05:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 23:30:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 23:30:52]

Dry run: This issue passed the CQ dry run.

[Guido Urdaneta, 2016-12-01 15:23:24]

lgtm % nit

https://codereview.chromium.org/2540263003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/mediastream/MediaStreamComponent.cpp
(right):

https://codereview.chromium.org/2540263003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/mediastream/MediaStreamComponent.cpp:68: //
TODO(pbos): Move properties from MediaStreamTrack here.
nit: File a bug about these?

[Guido Urdaneta, 2016-12-01 15:25:36]

Is it possible to write a test that triggers this bug?

[pbos, 2016-12-01 17:16:33]

Test added for enabled, didn't find a good way to trigger muted, but put a TODO
for it in the test.

https://codereview.chromium.org/2540263003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/mediastream/MediaStreamComponent.cpp
(right):

https://codereview.chromium.org/2540263003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/mediastream/MediaStreamComponent.cpp:68: //
TODO(pbos): Move properties from MediaStreamTrack here.
On 2016/12/01 15:23:24, Guido Urdaneta wrote:
> nit: File a bug about these?

Done, using the same bug since some properties are not cloned over.

[pbos, 2016-12-01 17:18:48]

The CQ bit was checked by pbos@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 17:19:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-12-01 17:21:10]

lgtm

[pbos, 2016-12-01 17:22:15]

The CQ bit was unchecked by pbos@chromium.org

[pbos, 2016-12-01 17:22:24]

The CQ bit was checked by pbos@chromium.org

[pbos, 2016-12-01 17:22:24]

The patchset sent to the CQ was uploaded after l-g-t-m from guidou@chromium.org
Link to the patchset: https://codereview.chromium.org/2540263003/#ps20001
(title: "added test + todo comments")

[commit-bot: I haz the power, 2016-12-01 17:23:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pbos, 2016-12-01 17:23:38]

Description was changed from

==========
Carry MediaStreamComponent properties on clone.

Adds a clone() method to MediaStreamComponent that carries over enabled
and muted state which should carry over when cloning a MediaStreamTrack.
MediaStreamTrack's id intentionally does not carry over and remains
unique.

R=guidou@chromium.org,hta@chromium.org,esprehn@chromium.org
BUG=669212
==========

to

==========
Carry MediaStreamComponent properties on clone.

Adds a clone() method to MediaStreamComponent that carries over enabled
and muted state which should carry over when cloning a MediaStreamTrack.

MediaStreamTrack's id intentionally does not carry over and remains
unique.

R=guidou@chromium.org,hta@chromium.org,esprehn@chromium.org
BUG=669212
==========

[pbos, 2016-12-01 17:24:21]

Description was changed from

==========
Carry MediaStreamComponent properties on clone.

Adds a clone() method to MediaStreamComponent that carries over enabled
and muted state which should carry over when cloning a MediaStreamTrack.

MediaStreamTrack's id intentionally does not carry over and remains
unique.

R=guidou@chromium.org,hta@chromium.org,esprehn@chromium.org
BUG=669212
==========

to

==========
Carry MediaStreamComponent properties on clone.

Adds a clone() method to MediaStreamComponent that carries over enabled
and muted state which should carry over when cloning a MediaStreamTrack.

MediaStreamTrack's id intentionally does not carry over and remains
unique.

R=guidou@chromium.org,esprehn@chromium.org
BUG=669212
==========

[commit-bot: I haz the power, 2016-12-01 18:38:36]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480612944067910,
"parent_rev": "fdf3584fde29bfc2c602cf4f6d0beff52e9d026e", "commit_rev":
"26dd78d9d792dfea14e2333f9a81f98ff739ab87"}

[commit-bot: I haz the power, 2016-12-01 18:39:07]

Description was changed from

==========
Carry MediaStreamComponent properties on clone.

Adds a clone() method to MediaStreamComponent that carries over enabled
and muted state which should carry over when cloning a MediaStreamTrack.

MediaStreamTrack's id intentionally does not carry over and remains
unique.

R=guidou@chromium.org,esprehn@chromium.org
BUG=669212
==========

to

==========
Carry MediaStreamComponent properties on clone.

Adds a clone() method to MediaStreamComponent that carries over enabled
and muted state which should carry over when cloning a MediaStreamTrack.

MediaStreamTrack's id intentionally does not carry over and remains
unique.

R=guidou@chromium.org,esprehn@chromium.org
BUG=669212
==========

[commit-bot: I haz the power, 2016-12-01 18:39:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-01 18:42:10]

Description was changed from

==========
Carry MediaStreamComponent properties on clone.

Adds a clone() method to MediaStreamComponent that carries over enabled
and muted state which should carry over when cloning a MediaStreamTrack.

MediaStreamTrack's id intentionally does not carry over and remains
unique.

R=guidou@chromium.org,esprehn@chromium.org
BUG=669212
==========

to

==========
Carry MediaStreamComponent properties on clone.

Adds a clone() method to MediaStreamComponent that carries over enabled
and muted state which should carry over when cloning a MediaStreamTrack.

MediaStreamTrack's id intentionally does not carry over and remains
unique.

R=guidou@chromium.org,esprehn@chromium.org
BUG=669212

Committed: https://crrev.com/b38248f051bc2022527cfb09040050ed15b23d8e
Cr-Commit-Position: refs/heads/master@{#435656}
==========

[commit-bot: I haz the power, 2016-12-01 18:42:11]

Patchset 2 (id:??) landed as
https://crrev.com/b38248f051bc2022527cfb09040050ed15b23d8e
Cr-Commit-Position: refs/heads/master@{#435656}