Issue 2540233003: Clean up UI WebContents when destroying VR Shell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2540233003: Clean up UI WebContents when destroying VR Shell. (Closed)

Created:
4 years ago by bshe

Modified:
4 years ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2924

Project:
chromium

Visibility:
Public.

Clean up UI WebContents when destroying VR Shell. Note that now our re-entry performance is worse than before, because we weren't recreating our WebContents before. We should look into either caching, pre-loading, or otherwise, to improve startup time. BUG=669065 Review-Url: https://codereview.chromium.org/2535853002 Cr-Commit-Position: refs/heads/master@{#434672} (cherry picked from commit 9da88a2254c9cde59bc7f266f420391a1ba9f3ec) Committed: https://chromium.googlesource.com/chromium/src/+/b6c58d88dd4c48bd622b2e3aa55e6d46e5912ea2

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

bshe

4 years ago (2016-11-30 23:08:04 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b6c58d88dd4c48bd622b2e3aa55e6d46e5912ea2.