Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1514)

Issue 2535853002: Clean up UI WebContents when destroying VR Shell. (Closed)

Created:
4 years ago by mthiesse
Modified:
4 years ago
Reviewers:
bshe
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up UI WebContents when destroying VR Shell. Note that now our re-entry performance is worse than before, because we weren't recreating our WebContents before. We should look into either caching, pre-loading, or otherwise, to improve startup time. BUG=669065 Committed: https://crrev.com/9da88a2254c9cde59bc7f266f420391a1ba9f3ec Cr-Commit-Position: refs/heads/master@{#434672}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
mthiesse
PTAL
4 years ago (2016-11-28 16:32:15 UTC) #2
bshe
On 2016/11/28 16:32:15, mthiesse wrote: > PTAL lgtm
4 years ago (2016-11-28 16:44:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2535853002/1
4 years ago (2016-11-28 16:49:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 17:23:11 UTC) #9
commit-bot: I haz the power
4 years ago (2016-11-28 17:24:40 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9da88a2254c9cde59bc7f266f420391a1ba9f3ec
Cr-Commit-Position: refs/heads/master@{#434672}

Powered by Google App Engine
This is Rietveld 408576698