Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2540203002:
NoStatePrefetch: Add a test to verify request priority (Closed)
DescriptionNoStatePrefetch: Add a test to verify request priority
This only checks the request priority. Next: attempt to reliably intercept cases
when request priority gets upgraded.
Changes prerender::test_utils::CreatePrefetchOnlyInterceptorOnIO(...) to a more
generic prerender::test_utils::InterceptRequestAndCount(..., callback).
BUG=none
Committed: https://crrev.com/ae30ad3a95877e47fc554c8e6d5767aa74bf7fe5
Cr-Commit-Position: refs/heads/master@{#437518}
Patch Set 1 #Patch Set 2 : removed include url_request_filter.h #
Total comments: 2
Patch Set 3 : expect a different priority on Android #
Messages
Total messages: 27 (18 generated)
The CQ bit was checked by pasko@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== NoStatePrefetch: Add a test to verify request priority This only checks the request priority. Next: attempt to reliably intercept cases when request priority gets upgraded. BUG=none ========== to ========== NoStatePrefetch: Add a test to verify request priority This only checks the request priority. Next: attempt to reliably intercept cases when request priority gets upgraded. Changes prerender::test_utils::CreatePrefetchOnlyInterceptorOnIO(...) to a more generic prerender::test_utils::InterceptRequestAndCount(..., callback). BUG=none ==========
Description was changed from ========== NoStatePrefetch: Add a test to verify request priority This only checks the request priority. Next: attempt to reliably intercept cases when request priority gets upgraded. Changes prerender::test_utils::CreatePrefetchOnlyInterceptorOnIO(...) to a more generic prerender::test_utils::InterceptRequestAndCount(..., callback). BUG=none ========== to ========== NoStatePrefetch: Add a test to verify request priority This only checks the request priority. Next: attempt to reliably intercept cases when request priority gets upgraded. Changes prerender::test_utils::CreatePrefetchOnlyInterceptorOnIO(...) to a more generic prerender::test_utils::InterceptRequestAndCount(..., callback). BUG=none ==========
pasko@chromium.org changed reviewers: + droger@chromium.org, mattcary@chromium.org
The CQ bit was checked by pasko@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm https://codereview.chromium.org/2540203002/diff/20001/chrome/browser/prerende... File chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc (right): https://codereview.chromium.org/2540203002/diff/20001/chrome/browser/prerende... chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc:503: #define MAYBE_IssuesIdlePriorityRequests DISABLED_IssuesIdlePriorityRequests Should we keep the test enabled on Android, but check for the corresponding priority?
The CQ bit was checked by pasko@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2540203002/diff/20001/chrome/browser/prerende... File chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc (right): https://codereview.chromium.org/2540203002/diff/20001/chrome/browser/prerende... chrome/browser/prerender/prerender_nostate_prefetch_browsertest.cc:503: #define MAYBE_IssuesIdlePriorityRequests DISABLED_IssuesIdlePriorityRequests On 2016/12/01 10:57:00, droger wrote: > Should we keep the test enabled on Android, but check for the corresponding > priority? Good idea. Done. PTAL. Since to bind a lambda the lambda has to be captureless, the preprocessor directives are very nested, sorry about that.
Thanks!
On 2016/12/01 12:16:24, droger wrote: > Thanks! It seems no bots are running these tests on Android, certainly not in CQ :(
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by pasko@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from droger@chromium.org Link to the patchset: https://codereview.chromium.org/2540203002/#ps40001 (title: "expect a different priority on Android")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481281129374690,
"parent_rev": "6c6e5c2553e7892a718c016eeb1863e9da091846", "commit_rev":
"4514fa94981f09cddf2ac376a12858257ac7e48f"}
Message was sent while issue was closed.
Description was changed from ========== NoStatePrefetch: Add a test to verify request priority This only checks the request priority. Next: attempt to reliably intercept cases when request priority gets upgraded. Changes prerender::test_utils::CreatePrefetchOnlyInterceptorOnIO(...) to a more generic prerender::test_utils::InterceptRequestAndCount(..., callback). BUG=none ========== to ========== NoStatePrefetch: Add a test to verify request priority This only checks the request priority. Next: attempt to reliably intercept cases when request priority gets upgraded. Changes prerender::test_utils::CreatePrefetchOnlyInterceptorOnIO(...) to a more generic prerender::test_utils::InterceptRequestAndCount(..., callback). BUG=none Review-Url: https://codereview.chromium.org/2540203002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== NoStatePrefetch: Add a test to verify request priority This only checks the request priority. Next: attempt to reliably intercept cases when request priority gets upgraded. Changes prerender::test_utils::CreatePrefetchOnlyInterceptorOnIO(...) to a more generic prerender::test_utils::InterceptRequestAndCount(..., callback). BUG=none Review-Url: https://codereview.chromium.org/2540203002 ========== to ========== NoStatePrefetch: Add a test to verify request priority This only checks the request priority. Next: attempt to reliably intercept cases when request priority gets upgraded. Changes prerender::test_utils::CreatePrefetchOnlyInterceptorOnIO(...) to a more generic prerender::test_utils::InterceptRequestAndCount(..., callback). BUG=none Committed: https://crrev.com/ae30ad3a95877e47fc554c8e6d5767aa74bf7fe5 Cr-Commit-Position: refs/heads/master@{#437518} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/ae30ad3a95877e47fc554c8e6d5767aa74bf7fe5 Cr-Commit-Position: refs/heads/master@{#437518} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
