Fix WebGL use of base/numerics

Fix WebGL use of base/numerics

TBR=kbr@chromium.org
BUG=668713
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/42745d115830d552eaa6adddc047223f49037c1a
Cr-Commit-Position: refs/heads/master@{#435310}

[jschuh, 2016-11-30 14:38:41]

Description was changed from

==========
Fix WebGL use of base/numerics

BUG=668713
==========

to

==========
Fix WebGL use of base/numerics

BUG=668713
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jschuh, 2016-11-30 15:57:52]

Description was changed from

==========
Fix WebGL use of base/numerics

BUG=668713
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix WebGL use of base/numerics

TBR=kbr@chromium.org
BUG=668713
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jschuh, 2016-11-30 15:57:52]

jschuh@chromium.org changed reviewers:
+ kbr@chromium.org

[jschuh, 2016-11-30 15:57:56]

The CQ bit was checked by jschuh@chromium.org

[commit-bot: I haz the power, 2016-11-30 15:58:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 17:24:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1480521476440730, "parent_rev":
"97f0b715d05fe18cdcb15a12a1bc4fe6b76a271d", "commit_rev":
"2d98e8842fae941157624ba7000fd896c25c9595"}

[commit-bot: I haz the power, 2016-11-30 17:25:19]

Description was changed from

==========
Fix WebGL use of base/numerics

TBR=kbr@chromium.org
BUG=668713
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix WebGL use of base/numerics

TBR=kbr@chromium.org
BUG=668713
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-11-30 17:25:20]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-30 17:28:51]

Description was changed from

==========
Fix WebGL use of base/numerics

TBR=kbr@chromium.org
BUG=668713
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix WebGL use of base/numerics

TBR=kbr@chromium.org
BUG=668713
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/42745d115830d552eaa6adddc047223f49037c1a
Cr-Commit-Position: refs/heads/master@{#435310}
==========

[commit-bot: I haz the power, 2016-11-30 17:28:52]

Patchset 1 (id:??) landed as
https://crrev.com/42745d115830d552eaa6adddc047223f49037c1a
Cr-Commit-Position: refs/heads/master@{#435310}

[Ken Russell (switch to Gerrit), 2016-11-30 21:50:17]

Thanks Justin for helping us clean this up.

Kai: do you think you could follow up this patch with the requested minor
fixups?

https://codereview.chromium.org/2540153003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
(right):

https://codereview.chromium.org/2540153003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:4104:
(pixels->byteLength() - offsetInBytes).ValueOrDie())) {
We should change this code so that if the temporary value isn't valid, we
generate GL_INVALID_VALUE.

https://codereview.chromium.org/2540153003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp
(right):

https://codereview.chromium.org/2540153003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp:2663:
unsigned residual = (checkedValue % params.alignment).ValueOrDie();
Same here.

[Ken Russell (switch to Gerrit), 2016-11-30 21:50:47]

LGTM after the fact FWIW.

[Kai Ninomiya, 2016-11-30 21:57:46]

On 2016/11/30 21:50:17, Ken Russell wrote:
> Thanks Justin for helping us clean this up.
> 
> Kai: do you think you could follow up this patch with the requested minor
> fixups?
> 
>
https://codereview.chromium.org/2540153003/diff/1/third_party/WebKit/Source/m...
> File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp
> (right):
> 
>
https://codereview.chromium.org/2540153003/diff/1/third_party/WebKit/Source/m...
> third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:4104:
> (pixels->byteLength() - offsetInBytes).ValueOrDie())) {
> We should change this code so that if the temporary value isn't valid, we
> generate GL_INVALID_VALUE.
> 
>
https://codereview.chromium.org/2540153003/diff/1/third_party/WebKit/Source/p...
> File third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp
> (right):
> 
>
https://codereview.chromium.org/2540153003/diff/1/third_party/WebKit/Source/p...
> third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp:2663:
> unsigned residual = (checkedValue % params.alignment).ValueOrDie();
> Same here.

OK, sure.