third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp - Issue 2540153003: Fix WebGL use of base/numerics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 2540153003: Fix WebGL use of base/numerics (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp » ('j') | third_party/WebKit/Source/platform/graphics/gpu/WebGLImageConversion.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

index 95af46d616493bafc19152481b5640fa7c76684a..ba3ec722328b5deba8ace916cff80e47fbb72d40 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

@@ -4101,8 +4101,7 @@ void WebGLRenderingContextBase::readPixelsHelper(GLint x,

}

if (!validateReadPixelsFuncParameters(

width, height, format, type, pixels,

- static_cast<long long>(pixels->byteLength() -

- offsetInBytes.ValueOrDie()))) {

+ (pixels->byteLength() - offsetInBytes).ValueOrDie())) {

Ken Russell (switch to Gerrit) 2016/11/30 21:50:17 We should change this code so that if the temporar

return;

}

clearIfComposited();