Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: ui/app_list/app_list_switches.h

Issue 253983002: Use centered app list position whenever virtual keyboard is enabled. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Only change shape when keyboard enabled (not when it *might* be enabled). Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/app_list/app_list_switches.h
diff --git a/ui/app_list/app_list_switches.h b/ui/app_list/app_list_switches.h
index 17b6716c149978303603787af3eb12c1e84d3118..2e027d61c036f4c5a8e07ce10fd2219d29f0c70c 100644
--- a/ui/app_list/app_list_switches.h
+++ b/ui/app_list/app_list_switches.h
@@ -29,6 +29,10 @@ bool APP_LIST_EXPORT IsAppInfoEnabled();
bool APP_LIST_EXPORT IsExperimentalAppListEnabled();
varkha 2014/04/30 16:20:15 This should also not be experimental anymore.
Matt Giuca 2014/05/05 06:18:05 This one is still experimental (it is different to
+// Determines whether either command-line switch was given for enabling the
+// experimental app list position. Do not use this when positioning the app
+// list; instead use AppListViewDelegate::UseExperimentalAppListPosition. It
+// checks a superset of the conditions that trigger the position.
bool APP_LIST_EXPORT IsExperimentalAppListPositionEnabled();
benwells 2014/04/30 06:40:30 Let's remove all traces of 'experimental' from the
Matt Giuca 2014/04/30 06:53:38 Should we also change the flag name, or is that fr
Matt Giuca 2014/05/05 06:18:05 Done.
} // namespace switches

Powered by Google App Engine
This is Rietveld 408576698