Use centered app list position whenever virtual keyboard is enabled.

ui/app_list/app_list_switches.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_APP_LIST_APP_LIST_SWITCHES_H_
 #define UI_APP_LIST_APP_LIST_SWITCHES_H_
 
 #include "ui/app_list/app_list_export.h"
 
 namespace app_list {
 namespace switches {
 
 // Please keep these flags sorted.
 APP_LIST_EXPORT extern const char kDisableSyncAppList[];
 APP_LIST_EXPORT extern const char kDisableVoiceSearch[];
 APP_LIST_EXPORT extern const char kEnableAppInfo[];
 APP_LIST_EXPORT extern const char kEnableExperimentalAppList[];
 APP_LIST_EXPORT extern const char kEnableExperimentalAppListPosition[];
 APP_LIST_EXPORT extern const char kEnableHotwordAlwaysOn[];
 APP_LIST_EXPORT extern const char kEnableSyncAppList[];
 
 bool APP_LIST_EXPORT IsAppListSyncEnabled();
 
 bool APP_LIST_EXPORT IsFolderUIEnabled();
 
 bool APP_LIST_EXPORT IsVoiceSearchEnabled();
 
 bool APP_LIST_EXPORT IsAppInfoEnabled();
 
 bool APP_LIST_EXPORT IsExperimentalAppListEnabled();

[varkha, 2014/04/30 16:20:15]

This should also not be experimental anymore.

[Matt Giuca, 2014/05/05 06:18:05]

This one is still experimental (it is different to
IsExperimentalAppListPositionEnabled; now IsCenteredAppListEnabled -- this one
also introduces a bunch of new experiments including switchable top-level
views).

 
+// Determines whether either command-line switch was given for enabling the
+// experimental app list position. Do not use this when positioning the app
+// list; instead use AppListViewDelegate::UseExperimentalAppListPosition. It
+// checks a superset of the conditions that trigger the position.
 bool APP_LIST_EXPORT IsExperimentalAppListPositionEnabled();

[benwells, 2014/04/30 06:40:30]

Let's remove all traces of 'experimental' from the code for this - it is no
longer experimental with your change. E.g. this could be
IsCenteredAppListEnabled.

[Matt Giuca, 2014/04/30 06:53:38]

Should we also change the flag name, or is that frowned upon?

[Matt Giuca, 2014/05/05 06:18:05]

Done.

 
 }  // namespace switches
 }  // namespace app_list
 
 #endif  // UI_APP_LIST_APP_LIST_SWITCHES_H_