Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2539543002: RELAND: ImageCapture: move image_capture.mojom from media/mojo/interfaces/ to media/capture/mojo/ (Closed)

Created:
4 years ago by mcasas
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, haraken, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, blink-reviews, alokp+watch_chromium.org, xjz+watch_chromium.org, darin (slow to review), miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

RELAND: ImageCapture: move image_capture.mojom from media/mojo/interfaces/ to media/capture/mojo/ Original CL was reverted due to breaking webkit_tests in chromium.webkit/builders/WebKit%20Mac10.9/builds/40056 This is due to a problem that already bit me :-) build infra script to zip up mojom files wasn't updated, ongoing in https://chromium-review.googlesource.com/c/414565/ Original CL description ------------------------------ ImageCapture: move image_capture.mojom to media/capture/mojo/ This CL moves image_capture.mojom from media/mojo/interfaces/ to media/capture/mojo/ where it belongs logically speaking, and updates BUILD.gns and include paths. image_capture.mojom was in media/mojo/interfaces because when it landed, media/capture/mojo was not existing. BUG=518807 TEST=No code touched, if compile passes, it works (but there's also content_browsertests). TBR=xhwang@chromium.org for the removal in media/mojo/interfaces/BUILD.gn Committed: https://crrev.com/bf36294b5f62e301213674fe554072b7507376e9 Cr-Commit-Position: refs/heads/master@{#434873}

Patch Set 1 : https://codereview.chromium.org/2526953002 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -134 lines) Patch
M content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/media/capture/image_capture_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M media/capture/content/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/mojo/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
A + media/capture/mojo/image_capture.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
M media/capture/video/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/blob_utils.h View 1 chunk +1 line, -1 line 0 comments Download
M media/capture/video/video_capture_device.h View 1 chunk +1 line, -1 line 0 comments Download
M media/mojo/interfaces/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
D media/mojo/interfaces/image_capture.mojom View 1 chunk +0 lines, -113 lines 0 comments Download
M services/video_capture/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imagecapture/resources/mock-imagecapture.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/ImageCapture.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/imagecapture/PhotoCapabilities.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539543002/1
4 years ago (2016-11-29 03:39:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 03:44:45 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-29 03:46:50 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf36294b5f62e301213674fe554072b7507376e9
Cr-Commit-Position: refs/heads/master@{#434873}

Powered by Google App Engine
This is Rietveld 408576698