Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2539503003: ARIA 1.1: implementation for aria-col-* and aria-row-*. (Closed)

Created:
4 years ago by dmazzoni
Modified:
3 years, 10 months ago
Reviewers:
hektve, aboxhall, David Greens, dcheng, anthony, williamchie, wicales, pascal.massimino
CC:
aboxhall, aboxhall+watch_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-html_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, dmazzoni, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, haraken, jam, je_julie, kinuko+watch, mac-reviews_chromium.org, mlamouri+watch-content_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ARIA 1.1: implementation for aria-col-* and aria-row-*. This patch adds implementation for aria-col-index, aria-col-count, aria- col-span, aria-row-index, aria-row-count, aria-row-span from ARIA 1.1, https://rawgit.com/w3c/aria/master/aria/aria.html. For windows, aria-col-count, aria-col-index, aria-row-count, aria-row- index, aria-col-span and aria-row-span are exposed as object attributes. Based on http://codereview.chromium.org/1547643002 by je_julie, which was in turn based on wkrev.com/190833 by n_wang. BUG=543050, 644766 Committed: https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3 Cr-Commit-Position: refs/heads/master@{#440852}

Patch Set 1 #

Total comments: 8

Patch Set 2 : Address feedback #

Total comments: 2

Patch Set 3 : rebase #

Patch Set 4 : Reword colindex on a row #

Patch Set 5 : Fix android expectations #

Patch Set 6 : Fix Mac #

Total comments: 2

Patch Set 7 : Rebase #

Patch Set 8 : Fix bad rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+540 lines, -24 lines) Patch
M content/browser/accessibility/accessibility_tree_formatter_mac.mm View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility.h View 1 2 3 4 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/accessibility/browser_accessibility.cc View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 2 3 4 5 6 6 chunks +55 lines, -2 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 3 4 5 6 3 chunks +35 lines, -7 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 3 4 5 6 2 chunks +8 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 2 3 4 5 6 7 4 chunks +34 lines, -11 lines 0 comments Download
A content/test/data/accessibility/aria/aria-col-attr.html View 1 chunk +20 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-col-attr-expected-android.txt View 1 2 3 4 1 chunk +16 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-col-attr-expected-blink.txt View 1 chunk +31 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-col-attr-expected-mac.txt View 1 chunk +23 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-col-attr-expected-win.txt View 1 chunk +23 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-row-attr.html View 1 chunk +18 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-row-attr-expected-android.txt View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-row-attr-expected-blink.txt View 1 chunk +24 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-row-attr-expected-mac.txt View 1 chunk +18 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria/aria-row-attr-expected-win.txt View 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAttributeNames.in View 1 2 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTable.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTable.cpp View 1 1 chunk +41 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTableCell.h View 3 chunks +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTableCell.cpp View 1 2 chunks +25 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTableRow.h View 3 chunks +5 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXTableRow.cpp View 1 2 3 2 chunks +33 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebAXObject.cpp View 1 2 3 4 5 6 2 chunks +44 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebAXObject.h View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M ui/accessibility/ax_enums.idl View 1 2 3 4 5 6 1 chunk +6 lines, -0 lines 0 comments Download
M ui/accessibility/ax_node_data.cc View 1 2 3 4 5 6 1 chunk +12 lines, -0 lines 0 comments Download
M ui/accessibility/ax_tree_combiner.cc View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 57 (29 generated)
dmazzoni
4 years ago (2016-11-28 21:02:35 UTC) #3
blink-reviews
Perfect! Thanks Dominic. Do we also need to implement these for ARIA grids? -- You ...
4 years ago (2016-11-28 21:05:32 UTC) #4
chromium-reviews
Perfect! Thanks Dominic. Do we also need to implement these for ARIA grids? -- You ...
4 years ago (2016-11-28 21:05:32 UTC) #5
nektarios
Perfect. Thanks so much! Do we also need to implement these for ARIA grids?
4 years ago (2016-11-28 21:07:13 UTC) #6
dmazzoni
The grid classes are all subclasses of the table classes so it should handle both ...
4 years ago (2016-11-28 21:47:46 UTC) #7
dmazzoni
The grid classes are all subclasses of the table classes so it should handle both ...
4 years ago (2016-11-28 21:47:46 UTC) #8
aboxhall
https://codereview.chromium.org/2539503003/diff/1/third_party/WebKit/Source/modules/accessibility/AXTable.cpp File third_party/WebKit/Source/modules/accessibility/AXTable.cpp (right): https://codereview.chromium.org/2539503003/diff/1/third_party/WebKit/Source/modules/accessibility/AXTable.cpp#newcode514 third_party/WebKit/Source/modules/accessibility/AXTable.cpp:514: const AtomicString& rowCountValue = getAttribute(aria_rowcountAttr); Any point checking hasAttribute ...
4 years ago (2016-11-29 17:36:54 UTC) #9
dmazzoni
https://codereview.chromium.org/2539503003/diff/1/third_party/WebKit/Source/modules/accessibility/AXTable.cpp File third_party/WebKit/Source/modules/accessibility/AXTable.cpp (right): https://codereview.chromium.org/2539503003/diff/1/third_party/WebKit/Source/modules/accessibility/AXTable.cpp#newcode514 third_party/WebKit/Source/modules/accessibility/AXTable.cpp:514: const AtomicString& rowCountValue = getAttribute(aria_rowcountAttr); On 2016/11/29 17:36:54, aboxhall ...
4 years ago (2016-11-30 22:48:17 UTC) #10
dmazzoni
Friendly ping?
4 years ago (2016-12-02 17:25:45 UTC) #15
aboxhall
lgtm https://codereview.chromium.org/2539503003/diff/20001/third_party/WebKit/Source/modules/accessibility/AXTableRow.cpp File third_party/WebKit/Source/modules/accessibility/AXTableRow.cpp (right): https://codereview.chromium.org/2539503003/diff/20001/third_party/WebKit/Source/modules/accessibility/AXTableRow.cpp#newcode53 third_party/WebKit/Source/modules/accessibility/AXTableRow.cpp:53: // A row is allowed to have a ...
4 years ago (2016-12-02 17:39:26 UTC) #16
dmazzoni
https://codereview.chromium.org/2539503003/diff/20001/third_party/WebKit/Source/modules/accessibility/AXTableRow.cpp File third_party/WebKit/Source/modules/accessibility/AXTableRow.cpp (right): https://codereview.chromium.org/2539503003/diff/20001/third_party/WebKit/Source/modules/accessibility/AXTableRow.cpp#newcode53 third_party/WebKit/Source/modules/accessibility/AXTableRow.cpp:53: // A row is allowed to have a column ...
4 years ago (2016-12-14 17:41:03 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539503003/100001
4 years ago (2016-12-16 06:45:33 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/327611)
4 years ago (2016-12-16 06:54:31 UTC) #28
dmazzoni
+dcheng for owners review of: third_party/WebKit/Source/core/html/HTMLAttributeNames.in third_party/WebKit/public/web/WebAXObject.h
4 years ago (2016-12-16 07:04:43 UTC) #30
dcheng
Also, does this need an intent? I couldn't tell from the linked bug. https://codereview.chromium.org/2539503003/diff/100001/third_party/WebKit/public/web/WebAXObject.h File ...
4 years ago (2016-12-16 08:53:42 UTC) #31
dmazzoni
Good point about the Intent thread. I started one on blink-dev just now. https://codereview.chromium.org/2539503003/diff/100001/third_party/WebKit/public/web/WebAXObject.h File ...
4 years ago (2016-12-20 18:16:32 UTC) #33
dcheng
LGTM, let's wait for the intent to implement and ship to get 3x LGTMs from ...
4 years ago (2016-12-20 19:20:14 UTC) #34
dmazzoni
Sounds good, will do!
4 years ago (2016-12-20 19:32:14 UTC) #35
dmazzoni
The intent thread on blink-dev got 3 lgtms, so adding cq+ now.
4 years ago (2016-12-21 22:22:11 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539503003/100001
4 years ago (2016-12-21 22:22:54 UTC) #38
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/126969) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-12-21 22:25:58 UTC) #40
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539503003/120001
3 years, 12 months ago (2016-12-27 04:42:09 UTC) #43
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/283447)
3 years, 12 months ago (2016-12-27 05:25:13 UTC) #45
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539503003/140001
3 years, 11 months ago (2016-12-28 15:03:56 UTC) #48
commit-bot: I haz the power
Committed patchset #8 (id:140001)
3 years, 11 months ago (2016-12-28 16:42:51 UTC) #51
commit-bot: I haz the power
Patchset 8 (id:??) landed as https://crrev.com/c5d4f1b146e762edcc6a86dd880c95da651d71d3 Cr-Commit-Position: refs/heads/master@{#440852}
3 years, 11 months ago (2017-01-02 15:49:07 UTC) #53
David Greens
lgtm
3 years, 10 months ago (2017-02-11 23:57:04 UTC) #55
David Greens
3 years, 10 months ago (2017-02-12 00:11:05 UTC) #57
Message was sent while issue was closed.
Project Chromium

Powered by Google App Engine
This is Rietveld 408576698