Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 2539503002: [heap] Assert that there's no recodred slot corresponding to unboxed double field. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Assert that there's no recodred slot corresponding to unboxed double field. BUG=chromium:666046 Committed: https://crrev.com/60f18c7918b784fb07cd6b5280f3220365cff49c Cr-Commit-Position: refs/heads/master@{#41330}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -0 lines) Patch
M src/heap/heap.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/heap/remembered-set.h View 1 chunk +13 lines, -0 lines 0 comments Download
M src/heap/slot-set.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
Igor Sheludko
PTAL
4 years ago (2016-11-28 19:40:57 UTC) #4
ulan
lgtm
4 years ago (2016-11-28 19:43:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539503002/1
4 years ago (2016-11-28 20:19:55 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 22:25:02 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-28 22:25:18 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/60f18c7918b784fb07cd6b5280f3220365cff49c
Cr-Commit-Position: refs/heads/master@{#41330}

Powered by Google App Engine
This is Rietveld 408576698