Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2539493002: [heap] Clear recorded slots for inobject properties when migrating fast object to slow mode. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Clear recorded slots for inobject properties when migrating fast object to slow mode. BUG=chromium:666046 Committed: https://crrev.com/a814b8aeaf2b56635054c96435972dce90576f62 Cr-Commit-Position: refs/heads/master@{#41327}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -3 lines) Patch
M src/objects.cc View 1 chunk +10 lines, -3 lines 0 comments Download
A test/mjsunit/regress/regress-666046.js View 1 chunk +57 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (7 generated)
Igor Sheludko
PTAL
4 years ago (2016-11-28 19:35:27 UTC) #2
ulan
lgtm! good catch.
4 years ago (2016-11-28 19:41:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539493002/1
4 years ago (2016-11-28 19:42:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-28 20:11:05 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-28 20:11:39 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a814b8aeaf2b56635054c96435972dce90576f62
Cr-Commit-Position: refs/heads/master@{#41327}

Powered by Google App Engine
This is Rietveld 408576698