Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 2539473002: Add "UNKNOWN_TILE_TYPE" for metrics (Closed)

Created:
4 years ago by sfiera
Modified:
4 years ago
Reviewers:
Marc Treib
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add "UNKNOWN_TILE_TYPE" for metrics iOS doesn't yet have any delegate method that fires when we have finished loading all the tiles on the NTP. Without that, it's not possible to reliably output metrics for tile types. Adding this (after NUM_RECORDED_TILE_TYPES) will let us proceed with the conversion to metrics::RecordPageImpression() in the meantime. BUG=669090 Committed: https://crrev.com/208aa90371f4c7f51ac7745125a076cef6861b75 Cr-Commit-Position: refs/heads/master@{#434985}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M components/ntp_tiles/metrics.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
sfiera
4 years ago (2016-11-28 17:26:25 UTC) #4
Marc Treib
lgtm
4 years ago (2016-11-29 14:13:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539473002/1
4 years ago (2016-11-29 14:38:14 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 14:43:09 UTC) #11
commit-bot: I haz the power
4 years ago (2016-11-29 14:45:26 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/208aa90371f4c7f51ac7745125a076cef6861b75
Cr-Commit-Position: refs/heads/master@{#434985}

Powered by Google App Engine
This is Rietveld 408576698