Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Side by Side Diff: components/ntp_tiles/metrics.h

Issue 2539473002: Add "UNKNOWN_TILE_TYPE" for metrics (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_NTP_TILES_METRICS_H_ 5 #ifndef COMPONENTS_NTP_TILES_METRICS_H_
6 #define COMPONENTS_NTP_TILES_METRICS_H_ 6 #define COMPONENTS_NTP_TILES_METRICS_H_
7 7
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 16 matching lines...) Expand all
27 ICON_REAL, 27 ICON_REAL,
28 // The item displays a color derived from the site's favicon or touch icon. 28 // The item displays a color derived from the site's favicon or touch icon.
29 ICON_COLOR, 29 ICON_COLOR,
30 // The item displays a default gray box in place of an icon. 30 // The item displays a default gray box in place of an icon.
31 ICON_DEFAULT, 31 ICON_DEFAULT,
32 // The number of different tile types that get recorded. Entries below this 32 // The number of different tile types that get recorded. Entries below this
33 // are not recorded in UMA. 33 // are not recorded in UMA.
34 NUM_RECORDED_TILE_TYPES, 34 NUM_RECORDED_TILE_TYPES,
35 // The item displays a thumbnail of the page. Used on desktop. 35 // The item displays a thumbnail of the page. Used on desktop.
36 THUMBNAIL, 36 THUMBNAIL,
37 // The tile type has not been determined yet. Used on iOS, until we can detect
38 // when all tiles have loaded.
39 UNKNOWN_TILE_TYPE,
37 }; 40 };
38 41
39 // Records an NTP impression, after all tiles have loaded. 42 // Records an NTP impression, after all tiles have loaded.
40 // Includes the visual types (see above) of all visible tiles. 43 // Includes the visual types (see above) of all visible tiles.
41 void RecordPageImpression( 44 void RecordPageImpression(
42 const std::vector<std::pair<NTPTileSource, MostVisitedTileType>>& tiles); 45 const std::vector<std::pair<NTPTileSource, MostVisitedTileType>>& tiles);
43 46
44 // Records a click on a tile. 47 // Records a click on a tile.
45 void RecordTileClick(int index, 48 void RecordTileClick(int index,
46 NTPTileSource source, 49 NTPTileSource source,
47 MostVisitedTileType tile_type); 50 MostVisitedTileType tile_type);
48 51
49 } // namespace metrics 52 } // namespace metrics
50 } // namespace ntp_tiles 53 } // namespace ntp_tiles
51 54
52 #endif 55 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698