Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 253943002: Remove CommandBuffer::GetState (Closed)

Created:
6 years, 7 months ago by piman
Modified:
6 years, 7 months ago
CC:
chromium-reviews, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org
Visibility:
Public.

Description

Remove CommandBuffer::GetState https://codereview.chromium.org/220243003 removed the last client-side caller. Service-side implementation of GetState is identical to GetLastState. So replace all instances of GetState by GetLastState and remove the former. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267027

Patch Set 1 #

Patch Set 2 : I forgot Poland^Wmojo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -144 lines) Patch
M content/common/gpu/client/command_buffer_proxy_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 6 chunks +5 lines, -19 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/pepper/ppb_graphics_3d_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/ppb_graphics_3d_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/client_test_helper.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/client/client_test_helper.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/client/cmd_buffer_helper_test.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/fenced_allocator_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/mapped_memory_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/ring_buffer_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/common/command_buffer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/common/command_buffer_mock.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/command_buffer_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/command_buffer_service.cc View 2 chunks +3 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/command_buffer_service_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gpu_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/gpu_scheduler_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M gpu/command_buffer/tests/gl_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/examples/pepper_container_app/graphics_3d_resource.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/examples/pepper_container_app/graphics_3d_resource.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/gles2/command_buffer_client_impl.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/gles2/command_buffer_client_impl.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download
M mojo/services/gles2/command_buffer_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.h View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ppapi/proxy/ppb_graphics_3d_proxy.cc View 3 chunks +0 lines, -18 lines 0 comments Download
M ppapi/thunk/ppb_graphics_3d_api.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
piman
jbauman: please review yzshen: OWNERS in ppapi/thunk jschuh: IPC security (removing a couple of messages)
6 years, 7 months ago (2014-04-29 00:09:13 UTC) #1
jbauman
lgtm, beat me to it :)
6 years, 7 months ago (2014-04-29 00:12:10 UTC) #2
piman
+viettrungluu for mojo
6 years, 7 months ago (2014-04-29 00:16:09 UTC) #3
yzshen1
On 2014/04/29 00:16:09, piman wrote: > +viettrungluu for mojo pepper LGTM
6 years, 7 months ago (2014-04-29 00:16:46 UTC) #4
jschuh
ipc security lgtm (message removal)
6 years, 7 months ago (2014-04-29 02:29:24 UTC) #5
viettrungluu
mojo lgtm
6 years, 7 months ago (2014-04-29 20:03:06 UTC) #6
piman
The CQ bit was checked by piman@chromium.org
6 years, 7 months ago (2014-04-29 20:26:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/253943002/20001
6 years, 7 months ago (2014-04-29 20:42:52 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 01:26:43 UTC) #9
Message was sent while issue was closed. 
Change committed as 267027

Powered by Google App Engine
This is Rietveld 408576698