Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 220243003: Avoid GetState IPC call during AllocateRingbuffer. (Closed)

Created:
6 years, 8 months ago by rptr
Modified:
6 years, 8 months ago
Reviewers:
jbauman, piman
CC:
sivag, vivekg_samsung, chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Avoid GetState IPC call during AllocateRingbuffer. SetGetBuffer(id) resets get and put offsets to 0. So no need to ask CommandBuffer::State through GetState() IPC call. CreateTransferBuffer() allocates new cmd buffer of size 1MB. No need to check for num_entries after new allocation of ring_buffer, as always state.num_entries==num_ring_buffer_entries after this new allocation. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=264166

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -13 lines) Patch
M gpu/command_buffer/client/cmd_buffer_helper.cc View 1 chunk +4 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
rptr
PTAL.
6 years, 8 months ago (2014-04-02 05:54:09 UTC) #1
piman
The patch is good. However, it doesn't look like you have been added to the ...
6 years, 8 months ago (2014-04-02 20:15:55 UTC) #2
rptr
On 2014/04/02 20:15:55, piman wrote: > The patch is good. > However, it doesn't look ...
6 years, 8 months ago (2014-04-03 17:51:15 UTC) #3
rptr
On 2014/04/03 17:51:15, rptr wrote: > On 2014/04/02 20:15:55, piman wrote: > > The patch ...
6 years, 8 months ago (2014-04-15 16:57:47 UTC) #4
piman
lgtm
6 years, 8 months ago (2014-04-15 22:17:32 UTC) #5
rptr
The CQ bit was checked by puttaraju.r@samsung.com
6 years, 8 months ago (2014-04-16 02:48:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/puttaraju.r@samsung.com/220243003/1
6 years, 8 months ago (2014-04-16 02:49:52 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-16 09:50:56 UTC) #8
Message was sent while issue was closed.
Change committed as 264166

Powered by Google App Engine
This is Rietveld 408576698