Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 2539363003: Don't include ComputedStyle.h where not needed. (Closed)

Created:
4 years ago by mstensho (USE GERRIT)
Modified:
4 years ago
Reviewers:
fs, rune
CC:
fs, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, krit, eae+blinkwatch, f(malita), gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Stephen Chennney, sof, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't include ComputedStyle.h where not needed. This reduces the dependency on ComputedStyle.h from more than 2000 compilation units to less than 1000. Committed: https://crrev.com/d7b40d656238df562cd53445383fd7ab3de28aea Cr-Commit-Position: refs/heads/master@{#435928}

Patch Set 1 #

Patch Set 2 : Don't include ComputedStyle.h where not needed. #

Patch Set 3 : Add ~HTMLOptGroupElement(). Comment stolen from ~HTMLOptionElement(). #

Messages

Total messages: 19 (14 generated)
mstensho (USE GERRIT)
4 years ago (2016-12-02 08:57:55 UTC) #4
fs
Drive-by LGTM!
4 years ago (2016-12-02 09:03:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539363003/40001
4 years ago (2016-12-02 13:21:25 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-02 13:25:27 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-02 13:29:22 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d7b40d656238df562cd53445383fd7ab3de28aea
Cr-Commit-Position: refs/heads/master@{#435928}

Powered by Google App Engine
This is Rietveld 408576698