Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2539363002: Add better Bookmark Manager drag and drop stats. (Closed)

Created:
4 years ago by calamity
Modified:
4 years ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, tfarina, arv+watch_chromium.org, dcheng, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add better Bookmark Manager drag and drop stats. This CL changes the drag stats in bookmark manager to be more granular and adds a histogram to track the number of bookmarks being dragged at once. BUG=665660 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/7be20a0c34d3811e658da9e932a868dddb635d80 Cr-Commit-Position: refs/heads/master@{#436524}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : re-add deleted actions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -3 lines) Patch
M chrome/browser/resources/bookmark_manager/js/dnd.js View 2 chunks +27 lines, -3 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 2 chunks +54 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
calamity
4 years ago (2016-12-02 04:35:58 UTC) #4
tsergeant
https://codereview.chromium.org/2539363002/diff/20001/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (left): https://codereview.chromium.org/2539363002/diff/20001/tools/metrics/actions/actions.xml#oldcode2370 tools/metrics/actions/actions.xml:2370: <owner>calamity@chromium.org</owner> I think these should be marked <obsolete> rather ...
4 years ago (2016-12-02 04:44:19 UTC) #5
calamity
https://codereview.chromium.org/2539363002/diff/20001/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (left): https://codereview.chromium.org/2539363002/diff/20001/tools/metrics/actions/actions.xml#oldcode2370 tools/metrics/actions/actions.xml:2370: <owner>calamity@chromium.org</owner> On 2016/12/02 04:44:19, tsergeant wrote: > I think ...
4 years ago (2016-12-05 00:12:20 UTC) #7
tsergeant
lgtm
4 years ago (2016-12-05 01:55:48 UTC) #8
Ilya Sherman
Metrics LGTM, though I'd recommend using a two histograms rather than 6 actions for these ...
4 years ago (2016-12-05 22:58:17 UTC) #9
calamity
On 2016/12/05 22:58:17, Ilya Sherman wrote: > Metrics LGTM, though I'd recommend using a two ...
4 years ago (2016-12-06 00:24:20 UTC) #10
calamity
+dbeam for dnd.js OWNERS.
4 years ago (2016-12-06 00:24:56 UTC) #14
Dan Beam
lgtm
4 years ago (2016-12-06 01:15:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539363002/40001
4 years ago (2016-12-06 03:00:55 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years ago (2016-12-06 04:33:57 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-06 04:37:42 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7be20a0c34d3811e658da9e932a868dddb635d80
Cr-Commit-Position: refs/heads/master@{#436524}

Powered by Google App Engine
This is Rietveld 408576698