Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3080)

Unified Diff: chrome/browser/resources/bookmark_manager/js/dnd.js

Issue 2539363002: Add better Bookmark Manager drag and drop stats. (Closed)
Patch Set: re-add deleted actions Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/metrics/actions/actions.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/bookmark_manager/js/dnd.js
diff --git a/chrome/browser/resources/bookmark_manager/js/dnd.js b/chrome/browser/resources/bookmark_manager/js/dnd.js
index 9f6df62de8c58590bb04e1e62ca02619e8f5c4f6..65f382b745038210694b9c28d420942046ced232 100644
--- a/chrome/browser/resources/bookmark_manager/js/dnd.js
+++ b/chrome/browser/resources/bookmark_manager/js/dnd.js
@@ -345,7 +345,18 @@ cr.define('dnd', function() {
chrome.bookmarkManagerPrivate.startDrag(draggedNodes.map(function(node) {
return node.id;
}), isFromTouch);
- chrome.metricsPrivate.recordUserAction('BookmarkManager_StartDrag');
+ var dragTarget = getBookmarkElement(e.target);
+ if (dragTarget instanceof ListItem ||
+ dragTarget instanceof BookmarkList) {
+ chrome.metricsPrivate.recordUserAction(
+ 'BookmarkManager_StartDragFromList');
+ } else if (dragTarget instanceof TreeItem) {
+ chrome.metricsPrivate.recordUserAction(
+ 'BookmarkManager_StartDragFromTree');
+ }
+
+ chrome.metricsPrivate.recordSmallCount(
+ 'BookmarkManager.NumDragged', draggedNodes.length);
}
}
@@ -485,9 +496,22 @@ cr.define('dnd', function() {
else
chrome.bookmarkManagerPrivate.drop(dropInfo.parentId);
- chrome.metricsPrivate.recordUserAction('BookmarkManager_Drop');
-
e.preventDefault();
+
+ var dragTarget = getBookmarkElement(e.target);
+ var action;
+ if (dragTarget instanceof ListItem ||
+ dragTarget instanceof BookmarkList) {
+ action = 'BookmarkManager_DropToList';
+ if (dropDestination.position == DropPosition.ON)
+ action = 'BookmarkManager_DropToListItem';
+ } else if (dragTarget instanceof TreeItem) {
+ action = 'BookmarkManager_DropToTree';
+ if (dropDestination.position == DropPosition.ON)
+ action = 'BookmarkManager_DropToTreeItem';
+ }
+ if (action)
+ chrome.metricsPrivate.recordUserAction(action);
}
dropDestination = null;
dropIndicator.finish();
« no previous file with comments | « no previous file | tools/metrics/actions/actions.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698