Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 2539323003: [HttpCacheTransaction] Ignore vary check for WriteMetadata requests (Closed)

Created:
4 years ago by jkarlin
Modified:
4 years ago
Reviewers:
gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, kinuko+cache_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[HttpCacheTransaction] Ignore vary check for WriteMetadata requests BUG=660264 Committed: https://crrev.com/dddb82a088ea0a9fe1e50e954a3e9dd6cb7f5a19 Cr-Commit-Position: refs/heads/master@{#437349}

Patch Set 1 #

Patch Set 2 : Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -2 lines) Patch
M net/base/load_flags_list.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/http/http_cache.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_cache_transaction.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/http/http_cache_unittest.cc View 1 1 chunk +64 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (10 generated)
jkarlin
gavinp@ PTAL at everything, thanks!
4 years ago (2016-12-01 15:49:53 UTC) #4
jkarlin
gavinp@ Ping!
4 years ago (2016-12-05 18:01:47 UTC) #7
gavinp
lgtm
4 years ago (2016-12-08 17:37:49 UTC) #8
jkarlin
Thanks!
4 years ago (2016-12-08 17:42:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539323003/20001
4 years ago (2016-12-08 17:42:33 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/82508)
4 years ago (2016-12-08 19:23:28 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2539323003/20001
4 years ago (2016-12-08 19:50:36 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-08 21:31:33 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-08 21:35:27 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dddb82a088ea0a9fe1e50e954a3e9dd6cb7f5a19
Cr-Commit-Position: refs/heads/master@{#437349}

Powered by Google App Engine
This is Rietveld 408576698