net/http/http_cache_transaction.cc - Issue 2539323003: [HttpCacheTransaction] Ignore vary check for WriteMetadata requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_cache_transaction.cc

Issue 2539323003: [HttpCacheTransaction] Ignore vary check for WriteMetadata requests (Closed)

Patch Set: Nits Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_cache_transaction.cc

diff --git a/net/http/http_cache_transaction.cc b/net/http/http_cache_transaction.cc

index b8f1eb06b2f9eae0f29072e47e64ecadb800d03e..a75f7381d1450d75e8f97c2b4fd1a7fd28e5bd7b 100644

--- a/net/http/http_cache_transaction.cc

+++ b/net/http/http_cache_transaction.cc

@@ -2246,7 +2246,8 @@ ValidationType HttpCache::Transaction::RequiresValidation() {

// - make sure we have a matching request method

// - watch out for cached responses that depend on authentication

- if (response_.vary_data.is_valid() &&

+ if (!(effective_load_flags_ & LOAD_SKIP_VARY_CHECK) &&

+ response_.vary_data.is_valid() &&

!response_.vary_data.MatchesRequest(*request_,

*response_.headers.get())) {

vary_mismatch_ = true;

« no previous file with comments | « net/http/http_cache.cc ('k') | net/http/http_cache_unittest.cc » ('j') | no next file with comments »