Convert loose FX_Create* functions into static methods

Convert loose FX_Create* functions into static methods

Also remove a bool that is always false.

Committed: https://pdfium.googlesource.com/pdfium/+/345d489b70a8e057587512524e69bd5692e2e14b

[Tom Sepez, 2016-11-30 18:11:46]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 18:11:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 18:26:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 18:26:25]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-11-30 20:39:25]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 20:39:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-11-30 20:47:16]

tsepez@chromium.org changed reviewers:
+ npm@chromium.org, weili@chromium.org

[Tom Sepez, 2016-11-30 20:47:17]

Wei, NPM, naming change only in some sense.

[Tom Sepez, 2016-11-30 20:48:22]

Description was changed from

==========
Convert loose FX_Create* functions into static methods
==========

to

==========
Convert loose FX_Create* functions into static methods

Also remove a bool that is always false.
==========

[commit-bot: I haz the power, 2016-11-30 20:54:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 20:54:46]

Dry run: This issue passed the CQ dry run.

[npm, 2016-11-30 22:58:01]

lgtm

https://codereview.chromium.org/2539203002/diff/40001/core/fxcrt/fx_extension...
File core/fxcrt/fx_extension.cpp (right):

https://codereview.chromium.org/2539203002/diff/40001/core/fxcrt/fx_extension...
core/fxcrt/fx_extension.cpp:342: IFX_SeekableStream*
IFX_SeekableStream::CreateFromFilename(
Are there creates that are not from filename, or why the naming?

https://codereview.chromium.org/2539203002/diff/40001/xfa/fgas/crt/fgas_strea...
File xfa/fgas/crt/fgas_stream.cpp (right):

https://codereview.chromium.org/2539203002/diff/40001/xfa/fgas/crt/fgas_strea...
xfa/fgas/crt/fgas_stream.cpp:1455: IFX_SeekableReadStream*
IFX_Stream::MakeSeekableReadStream() {
Why make here instead of Create?

[Tom Sepez, 2016-11-30 23:09:44]

https://codereview.chromium.org/2539203002/diff/40001/core/fxcrt/fx_extension...
File core/fxcrt/fx_extension.cpp (right):

https://codereview.chromium.org/2539203002/diff/40001/core/fxcrt/fx_extension...
core/fxcrt/fx_extension.cpp:342: IFX_SeekableStream*
IFX_SeekableStream::CreateFromFilename(
On 2016/11/30 22:58:00, npm wrote:
> Are there creates that are not from filename, or why the naming?

In theory, you could make a seekable stream out of a data buffer buffer.  The
name is to indicate that we're not going to use the argument as the raw contents
itself.

https://codereview.chromium.org/2539203002/diff/40001/xfa/fgas/crt/fgas_strea...
File xfa/fgas/crt/fgas_stream.cpp (right):

https://codereview.chromium.org/2539203002/diff/40001/xfa/fgas/crt/fgas_strea...
xfa/fgas/crt/fgas_stream.cpp:1455: IFX_SeekableReadStream*
IFX_Stream::MakeSeekableReadStream() {
On 2016/11/30 22:58:00, npm wrote:
> Why make here instead of Create?

Layering.  IFX_SeekableReadStream is in core/ and can't know that XFA has an
IFX_Stream.

[Tom Sepez, 2016-11-30 23:10:29]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-11-30 23:10:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 23:10:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1480547429423130,
"parent_rev": "47718fbaf24000877aff58d9512b9b1dea0af818", "commit_rev":
"345d489b70a8e057587512524e69bd5692e2e14b"}

[commit-bot: I haz the power, 2016-11-30 23:10:59]

Description was changed from

==========
Convert loose FX_Create* functions into static methods

Also remove a bool that is always false.
==========

to

==========
Convert loose FX_Create* functions into static methods

Also remove a bool that is always false.

Committed:
https://pdfium.googlesource.com/pdfium/+/345d489b70a8e057587512524e69bd5692e2...
==========

[commit-bot: I haz the power, 2016-11-30 23:11:00]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/345d489b70a8e057587512524e69bd5692e2...